Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated code to fix dist issue with env in settings file #243

Merged
merged 1 commit into from
Jul 20, 2023

Conversation

sandeep-vedam
Copy link
Contributor

Following are the scenarios that are verified using the fix:

I have verified this with below cases :

With no esEnv setting in setings.json file
lng dist : Creates dist version of es6
lng dist --es6 : Creates dist version of es6
lng dist --es5: Created dist version of es5
lng dist --es5 --es6 : Creates both es5 and es6

With esEnv setting in setings.json file
lng dist & esEnv:es5 : Creates dist version of es5
lng dist & esEnv:es6 : Creates dist version of es5
lng dist --<es5/es6> & esEnv:es5 : Creates dist version of es5/es6 and ignores the settings.json file esEnv

With different settings file(for ex: settings.es5.json)
lng dist & esEnv:es5 : Creates dist version of es5
lng dist & esEnv:es6 : Creates dist version of es5
lng dist --<es5/es6> & esEnv:es5 : Creates dist version of es5/es6 and ignores the settings.json file esEnv

@sandeep-vedam sandeep-vedam linked an issue Jul 12, 2023 that may be closed by this pull request
@sandeep-vedam sandeep-vedam mentioned this pull request Jun 22, 2023
2 tasks
Copy link
Contributor

@michielvandergeest michielvandergeest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cidevant would appreciate if you can take this change for a spin and see if it's fixed fo you as well 😄

@michielvandergeest michielvandergeest merged commit 3b1f8b7 into dev Jul 20, 2023
@uguraslan uguraslan mentioned this pull request Jul 27, 2023
2 tasks
@sandeep-vedam sandeep-vedam deleted the fix/esEnv-dist branch March 7, 2024 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LNG DIST ignores esEnv parameter in settings.json
2 participants