Updated code to fix dist issue with env in settings file #243
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following are the scenarios that are verified using the fix:
I have verified this with below cases :
With no esEnv setting in setings.json file
lng dist : Creates dist version of es6
lng dist --es6 : Creates dist version of es6
lng dist --es5: Created dist version of es5
lng dist --es5 --es6 : Creates both es5 and es6
With esEnv setting in setings.json file
lng dist & esEnv:es5 : Creates dist version of es5
lng dist & esEnv:es6 : Creates dist version of es5
lng dist --<es5/es6> & esEnv:es5 : Creates dist version of es5/es6 and ignores the settings.json file esEnv
With different settings file(for ex: settings.es5.json)
lng dist & esEnv:es5 : Creates dist version of es5
lng dist & esEnv:es6 : Creates dist version of es5
lng dist --<es5/es6> & esEnv:es5 : Creates dist version of es5/es6 and ignores the settings.json file esEnv