fix(Knob): rename _updateCircleLayout to _updateLayout #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shanteaustin
requested review from
erautenberg,
joshhowenstine,
anthony9187,
ImCoolNowRight,
soumyaloka,
ctoddy and
cee-money
as code owners
|
b'## WARNING: A Blackduck scan failure has been waived A prior failure has been upvoted
|
shanteaustin
changed the title
|
Tested it, working for me! Thanks |
ImCoolNowRight
approved these changes
Sep 26, 2024
|
Can we just update the title to "fix(Knob): rename _updateCircleLayout to _updateLayout"? We can include the ScrollWrapper and FocusRing info in the description, but since this PR will get squashed and merged, it'd be nice to have the changelog show that this is a Knob, which is something that then propagates to the ScrollWrapper. |
joshhowenstine
approved these changes
Sep 27, 2024
ImCoolNowRight
force-pushed
the
feat/ScrollWrapperKnob
branch
from
1d9c07e to
e94faac
Compare
ImCoolNowRight
changed the title
ImCoolNowRight
pushed a commit
that referenced
this pull request
Sep 27, 2024
svc-lightning-ui-components
pushed a commit
that referenced
this pull request
Sep 27, 2024
# [@lightningjs/ui-components-v2.23.1](https://github.com/rdkcentral/Lightning-UI-Components/compare/@lightningjs/ui-components-v2.23.0...@lightningjs/ui-components-v2.23.1) (2024-09-27) ### Bug Fixes * **Knob:** rename _updateCircleLayout to _updateLayout ([#539](#539)) ([638aabd](638aabd)) * make sure subThemes are taken into account when generating style cache ([#534](#534)) ([fbcad55](fbcad55)) * **withThemeStylesDocs:** doc missing Source section ([#540](#540)) ([59873c1](59873c1))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates Knob's
_updateCircleLayoutto_updateLayoutto line up with check used in internal FocusRing extension.References
LUI-1573
Testing
Checklist