fix(withThemeStylesDocs): doc missing Source section #540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctoddy
requested review from
erautenberg,
joshhowenstine,
anthony9187,
ImCoolNowRight,
soumyaloka and
cee-money
as code owners
joshhowenstine
approved these changes
Sep 26, 2024
ImCoolNowRight
approved these changes
Sep 26, 2024
svc-lightning-ui-components
pushed a commit
that referenced
this pull request
Sep 27, 2024
# [@lightningjs/ui-components-v2.23.1](https://github.com/rdkcentral/Lightning-UI-Components/compare/@lightningjs/ui-components-v2.23.0...@lightningjs/ui-components-v2.23.1) (2024-09-27) ### Bug Fixes * **Knob:** rename _updateCircleLayout to _updateLayout ([#539](#539)) ([638aabd](638aabd)) * make sure subThemes are taken into account when generating style cache ([#534](#534)) ([fbcad55](fbcad55)) * **withThemeStylesDocs:** doc missing Source section ([#540](#540)) ([59873c1](59873c1))
|
🎉 This PR is included in version @lightningjs/ui-components-v2.23.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hyperlinks in the withThemeStyles documentation (both inner and open source) was missing the "Source" section causing the hyperlinks within this doc to fail and only result in a blank page when clicked on. Adding the "Source" sections fixes this bug.
References
https://ccp.sys.comcast.net/browse/LUI-1514
Testing
Run locally, navigate to withThemeStyles documentation, click on hyperlinks within this doc and observe they route to their respective doc.
Automation
Checklist