Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate Community/Tools/UI Components page #128

Merged
merged 3 commits into from
Apr 15, 2019
Merged

Translate Community/Tools/UI Components page #128

merged 3 commits into from
Apr 15, 2019

Conversation

linsolas
Copy link
Contributor

Hello,

Voici ma traduction pour https://reactjs.org/community/ui-components.html

(à noter que j'ai remplacé react-switch-button déprécié par react-toggle.
Il faudrait peut-être le faire aussi sur la page en VO...

@netlify
Copy link

netlify bot commented Mar 22, 2019

Deploy preview for fr-reactjs ready!

Built with commit 813f51c

https://deploy-preview-128--fr-reactjs.netlify.com

@sheplu sheplu added the Pending Review Un mainteneur qualifié doit encore faire la revue de cette PR label Mar 26, 2019
Copy link
Collaborator

@sheplu sheplu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hello,
quelques petits manques de S et harmonisation avec le glossaire pour appli

content/community/tools-ui-components.md Outdated Show resolved Hide resolved
content/community/tools-ui-components.md Outdated Show resolved Hide resolved
content/community/tools-ui-components.md Outdated Show resolved Hide resolved
content/community/tools-ui-components.md Outdated Show resolved Hide resolved
content/community/tools-ui-components.md Outdated Show resolved Hide resolved
content/community/tools-ui-components.md Outdated Show resolved Hide resolved
content/community/tools-ui-components.md Outdated Show resolved Hide resolved
content/community/tools-ui-components.md Outdated Show resolved Hide resolved
content/community/tools-ui-components.md Outdated Show resolved Hide resolved
content/community/tools-ui-components.md Outdated Show resolved Hide resolved
@tdd tdd added Reviewing Un mainteneur qualifié est en train de composer la revue de code and removed Pending Review Un mainteneur qualifié doit encore faire la revue de cette PR labels Apr 2, 2019
@tdd tdd self-requested a review April 2, 2019 20:13
@tdd tdd self-assigned this Apr 2, 2019
Copy link
Collaborator

@tdd tdd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Salut @linsolas !

Avant toute chose, merci pour tout ce boulot ! C'est super cool de nous filer un coup de main.

Avant de traiter les retours, lis bien TOUT ce message, notamment les consignes d'intégration optimale des retours par lot(s)

C'est du cosmétique ; attention, les "oui !" et 👍 se rapportent aux suggestions de @sheplu que j'ai plussoyées telles quelles.

Tout est fait sous forme de Suggestions GitHub, il te suffit à chaque suggestion que tu approuves de
cliquer le bouton d'ajout au lot de modifs à committer (pas de commit direct !), et sur la fin de créer le commit groupé. (ce mode de regroupement en un seul commit est à favoriser absolument, mais tu devras aller dans l'onglet Files changed pour y accéder, il n'est pas utilisable dans l’onglet Conversation)

Si certaines appellent discussion, n'hésite pas, tu réponds, on en parle, on avance ensemble 🤝

Quand tout sera bouclé côté code, je ferai une repasse visuelle finale en local avant de fusionner.

Encore mille mercis, j'ai hâte de voir cette PR finalisée et dans master !

content/community/tools-ui-components.md Outdated Show resolved Hide resolved
content/community/tools-ui-components.md Outdated Show resolved Hide resolved
content/community/tools-ui-components.md Outdated Show resolved Hide resolved
content/community/tools-ui-components.md Outdated Show resolved Hide resolved
content/community/tools-ui-components.md Outdated Show resolved Hide resolved
content/community/tools-ui-components.md Outdated Show resolved Hide resolved
content/community/tools-ui-components.md Outdated Show resolved Hide resolved
content/community/tools-ui-components.md Outdated Show resolved Hide resolved
content/community/tools-ui-components.md Outdated Show resolved Hide resolved
content/community/tools-ui-components.md Outdated Show resolved Hide resolved
@tdd tdd added Reviewed and removed Reviewing Un mainteneur qualifié est en train de composer la revue de code labels Apr 15, 2019
linsolas and others added 2 commits April 15, 2019 16:10
Co-Authored-By: linsolas <linsolas@gmail.com>
@tdd tdd merged commit 82f1a29 into reactjs:master Apr 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants