Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update 2018-10-23-react-v-16-6.md #179

Merged
merged 43 commits into from
Oct 16, 2019
Merged

Update 2018-10-23-react-v-16-6.md #179

merged 43 commits into from
Oct 16, 2019

Conversation

MustaphaLimam
Copy link
Contributor

Traduction terminée

@netlify
Copy link

netlify bot commented Jul 25, 2019 •
edited
Loading

Deploy preview for fr-reactjs ready!

Built with commit 491561f

https://deploy-preview-179--fr-reactjs.netlify.com

@MustaphaLimam
Update in 2018-10-23-react-v-16-6.md
e8904f6 
Rectification de quelques détails. 
Page finalement traduite.
@tdd tdd added the Pending Review Un mainteneur qualifié doit encore faire la revue de cette PR label Sep 12, 2019
@tdd tdd self-assigned this Sep 12, 2019
tdd
tdd requested changes Sep 13, 2019
View reviewed changes
Copy link
Collaborator

@tdd tdd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Salut @MustaphaLimam !

Avant toute chose, merci pour tout ce boulot ! C'est super cool de nous filer un coup de main.

Avant de traiter les retours, lis bien TOUT ce message, notamment les consignes d'intégration optimale des retours par lot(s)

Tout est fait sous forme de Suggestions GitHub, il te suffit à chaque suggestion que tu approuves de
cliquer le bouton d'ajout au lot de modifs à committer (pas de commit direct !), et sur la fin de créer le commit groupé. (ce mode de regroupement en un seul commit est à favoriser absolument, mais tu devras aller dans l'onglet Files changed pour y accéder, il n'est pas utilisable dans l’onglet Conversation)

En gros c'est surtout de la remise en cohérence de certains choix de trads, et de l'homogénéisation avec les autres trads de notes de versions. Y'a aussi un ou deux petits contre-sens pas bien méchants. Mais c'est vraiment pas mal !

Si certaines appellent discussion, n'hésite pas, tu réponds, on en parle, on avance ensemble 🤝

Quand tout sera bouclé côté code, je ferai une repasse visuelle finale en local avant de fusionner.

Encore mille mercis, j'ai hâte de voir cette PR finalisée et dans master !

content/blog/2018-10-23-react-v-16-6.md Outdated Show resolved Hide resolved
content/blog/2018-10-23-react-v-16-6.md Outdated Show resolved Hide resolved
content/blog/2018-10-23-react-v-16-6.md Outdated Show resolved Hide resolved
content/blog/2018-10-23-react-v-16-6.md Outdated Show resolved Hide resolved
content/blog/2018-10-23-react-v-16-6.md Outdated Show resolved Hide resolved
content/blog/2018-10-23-react-v-16-6.md Outdated Show resolved Hide resolved
content/blog/2018-10-23-react-v-16-6.md Outdated Show resolved Hide resolved
content/blog/2018-10-23-react-v-16-6.md Outdated Show resolved Hide resolved
content/blog/2018-10-23-react-v-16-6.md Outdated Show resolved Hide resolved
content/blog/2018-10-23-react-v-16-6.md Outdated Show resolved Hide resolved
@tdd tdd added Reviewed and removed Pending Review Un mainteneur qualifié doit encore faire la revue de cette PR labels Sep 13, 2019
MustaphaLimam and others added 22 commits September 22, 2019 11:59
@MustaphaLimam @tdd
Update content/blog/2018-10-23-react-v-16-6.md
d46c6d8 
Co-Authored-By: Christophe Porteneuve <tdd@tddsworld.com>
@MustaphaLimam @tdd
Update content/blog/2018-10-23-react-v-16-6.md
98e7c13 
Co-Authored-By: Christophe Porteneuve <tdd@tddsworld.com>
@MustaphaLimam @tdd
Update content/blog/2018-10-23-react-v-16-6.md
7844803 
Co-Authored-By: Christophe Porteneuve <tdd@tddsworld.com>
@MustaphaLimam @tdd
Update content/blog/2018-10-23-react-v-16-6.md
a89505c 
Co-Authored-By: Christophe Porteneuve <tdd@tddsworld.com>
@MustaphaLimam @tdd
Update content/blog/2018-10-23-react-v-16-6.md
7903afb 
Co-Authored-By: Christophe Porteneuve <tdd@tddsworld.com>
@MustaphaLimam @tdd
Update content/blog/2018-10-23-react-v-16-6.md
abb9f6a 
Co-Authored-By: Christophe Porteneuve <tdd@tddsworld.com>
@MustaphaLimam @tdd
Update content/blog/2018-10-23-react-v-16-6.md
86c0e91 
Co-Authored-By: Christophe Porteneuve <tdd@tddsworld.com>
@MustaphaLimam @tdd
Update content/blog/2018-10-23-react-v-16-6.md
8a2387d 
Co-Authored-By: Christophe Porteneuve <tdd@tddsworld.com>
@MustaphaLimam @tdd
Update content/blog/2018-10-23-react-v-16-6.md
978fe14 
Co-Authored-By: Christophe Porteneuve <tdd@tddsworld.com>
@MustaphaLimam @tdd
Update content/blog/2018-10-23-react-v-16-6.md
76c7a07 
Co-Authored-By: Christophe Porteneuve <tdd@tddsworld.com>
@MustaphaLimam @tdd
Update content/blog/2018-10-23-react-v-16-6.md
d44aa4c 
Co-Authored-By: Christophe Porteneuve <tdd@tddsworld.com>
@MustaphaLimam @tdd
Update content/blog/2018-10-23-react-v-16-6.md
fa4c5bc 
Co-Authored-By: Christophe Porteneuve <tdd@tddsworld.com>
@MustaphaLimam @tdd
Update content/blog/2018-10-23-react-v-16-6.md
3a4efa9 
Co-Authored-By: Christophe Porteneuve <tdd@tddsworld.com>
@MustaphaLimam @tdd
Update content/blog/2018-10-23-react-v-16-6.md
617ab19 
Co-Authored-By: Christophe Porteneuve <tdd@tddsworld.com>
@MustaphaLimam @tdd
Update content/blog/2018-10-23-react-v-16-6.md
395db4c 
Co-Authored-By: Christophe Porteneuve <tdd@tddsworld.com>
@MustaphaLimam @tdd
Update content/blog/2018-10-23-react-v-16-6.md
cd81bb1 
Co-Authored-By: Christophe Porteneuve <tdd@tddsworld.com>
@MustaphaLimam @tdd
Update content/blog/2018-10-23-react-v-16-6.md
8264a84 
Co-Authored-By: Christophe Porteneuve <tdd@tddsworld.com>
@MustaphaLimam @tdd
Update content/blog/2018-10-23-react-v-16-6.md
9ebe38a 
Co-Authored-By: Christophe Porteneuve <tdd@tddsworld.com>
@MustaphaLimam @tdd
Update content/blog/2018-10-23-react-v-16-6.md
3ff062c 
Co-Authored-By: Christophe Porteneuve <tdd@tddsworld.com>
@MustaphaLimam @tdd
Update content/blog/2018-10-23-react-v-16-6.md
08d169c 
Co-Authored-By: Christophe Porteneuve <tdd@tddsworld.com>
@MustaphaLimam @tdd
Update content/blog/2018-10-23-react-v-16-6.md
38fc159 
Co-Authored-By: Christophe Porteneuve <tdd@tddsworld.com>
@MustaphaLimam @tdd
Update content/blog/2018-10-23-react-v-16-6.md
fa948b8 
Co-Authored-By: Christophe Porteneuve <tdd@tddsworld.com>
MustaphaLimam and others added 18 commits September 22, 2019 12:07
@MustaphaLimam @tdd
Update content/blog/2018-10-23-react-v-16-6.md
62011c4 
Co-Authored-By: Christophe Porteneuve <tdd@tddsworld.com>
@MustaphaLimam @tdd
Update content/blog/2018-10-23-react-v-16-6.md
09ea9e1 
Co-Authored-By: Christophe Porteneuve <tdd@tddsworld.com>
@MustaphaLimam @tdd
Update content/blog/2018-10-23-react-v-16-6.md
d62444b 
Co-Authored-By: Christophe Porteneuve <tdd@tddsworld.com>
@MustaphaLimam @tdd
Update content/blog/2018-10-23-react-v-16-6.md
8b8e4a3 
Co-Authored-By: Christophe Porteneuve <tdd@tddsworld.com>
@MustaphaLimam @tdd
Update content/blog/2018-10-23-react-v-16-6.md
bfcb497 
Co-Authored-By: Christophe Porteneuve <tdd@tddsworld.com>
@MustaphaLimam @tdd
Update content/blog/2018-10-23-react-v-16-6.md
d42c5c8 
Co-Authored-By: Christophe Porteneuve <tdd@tddsworld.com>
@MustaphaLimam @tdd
Update content/blog/2018-10-23-react-v-16-6.md
6c4ac7b 
Co-Authored-By: Christophe Porteneuve <tdd@tddsworld.com>
@MustaphaLimam @tdd
Update content/blog/2018-10-23-react-v-16-6.md
e37ee71 
Co-Authored-By: Christophe Porteneuve <tdd@tddsworld.com>
@MustaphaLimam @tdd
Update content/blog/2018-10-23-react-v-16-6.md
2308bde 
Co-Authored-By: Christophe Porteneuve <tdd@tddsworld.com>
@MustaphaLimam @tdd
Update content/blog/2018-10-23-react-v-16-6.md
1a77c20 
Co-Authored-By: Christophe Porteneuve <tdd@tddsworld.com>
@MustaphaLimam @tdd
Update content/blog/2018-10-23-react-v-16-6.md
053e414 
Co-Authored-By: Christophe Porteneuve <tdd@tddsworld.com>
@MustaphaLimam @tdd
Update content/blog/2018-10-23-react-v-16-6.md
356925c 
Co-Authored-By: Christophe Porteneuve <tdd@tddsworld.com>
@MustaphaLimam @tdd
Update content/blog/2018-10-23-react-v-16-6.md
c7d3689 
Co-Authored-By: Christophe Porteneuve <tdd@tddsworld.com>
@MustaphaLimam @tdd
Update content/blog/2018-10-23-react-v-16-6.md
a27e1b0 
Co-Authored-By: Christophe Porteneuve <tdd@tddsworld.com>
@MustaphaLimam @tdd
Update content/blog/2018-10-23-react-v-16-6.md
52dc9a1 
Co-Authored-By: Christophe Porteneuve <tdd@tddsworld.com>
@MustaphaLimam @tdd
Update content/blog/2018-10-23-react-v-16-6.md
dd5591b 
Co-Authored-By: Christophe Porteneuve <tdd@tddsworld.com>
@MustaphaLimam @tdd
Update content/blog/2018-10-23-react-v-16-6.md
fd3b0e9 
Co-Authored-By: Christophe Porteneuve <tdd@tddsworld.com>
@MustaphaLimam @tdd
Update content/blog/2018-10-23-react-v-16-6.md
e245923 
Co-Authored-By: Christophe Porteneuve <tdd@tddsworld.com>
@MustaphaLimam MustaphaLimam requested a review from tdd October 10, 2019 09:18
@tdd tdd merged commit fe1a1d4 into reactjs:master Oct 16, 2019
@tesseralis tesseralis mentioned this pull request Oct 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdd tdd tdd approved these changes

Assignees

@tdd tdd

Labels
Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MustaphaLimam @tdd