Fix TransitionGroup error on quick toggle of components #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How sure are we that returning is the correct behavior? By just immediately returning, Previous attempts (#6710, #6745) only guarded execution of code that directly depends on Unless there's a good case for immediately returning, I think just guarding the |
|
I agree with @xStrom, we shouln't return early here, but guard the actual callback so the rest of the state can be properly cleaned up |
Fix TransitionGroup error on quick toggle of components
|
@xStrom I have just updated the PR |
|
Looks good, I think we should merge this. |
jony89
added a commit
to jony89/react-transition-group
that referenced
this pull request
Jan 27, 2018
fixes reactjs#12 using reactjs#15 for v1 as well. Not all of us has been moved to v2 (especially those of us who are still using `material-ui` < v1-beta), Yet, this is critical bug fix . hopefully a version with that fix will be released soon ? :)
jquense
pushed a commit
that referenced
this pull request
Jan 29, 2018
* Fix TransitionGroup error for v1 as well fixes #12 using #15 for v1 as well. Not all of us has been moved to v2 (especially those of us who are still using `material-ui` < v1-beta), Yet, this is critical bug fix . hopefully a version with that fix will be released soon ? :) * Update TransitionGroup.js
This was referenced Sep 22, 2018
Merged
1 task
This was referenced Jan 7, 2019
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had this pull request to address this issue: #12