Prevent this.setState if there is no component
#68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On `_handleDoneLeaving`, prevent calling `setState` if the component is unmounted. This was triggering this error: > Warning: setState(...): Can only update a mounted or mounting component. This usually means you called setState() on an unmounted component. This is a no-op. Please check the code for the ReactTransitionGroup component.
jquense
reviewed
Jun 12, 2017
| @@ -437,7 +437,7 @@ var TransitionGroup = function (_React$Component) { | |||
| if (currentChildMapping && currentChildMapping.hasOwnProperty(key)) { | |||
| // This entered again before it fully left. Add it again. | |||
| _this.performEnter(key); | |||
| } else { | |||
| } else if (component) { | |||
There was a problem hiding this comment.
this component isn't the TransitionGroup instance. The error would be related to TransitionGroup not being mounted when setState is called, it'd be better to check if the current component is mounted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On
_handleDoneLeaving, prevent callingsetStateif the component is unmounted.This was triggering this error:
This happened on a very complex structure and I was not able to reproduce it with sample code.
It is related to #15.