Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent this.setState if there is no component #68

Closed
wants to merge 1 commit into from
Closed

Prevent this.setState if there is no component #68

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -437,7 +437,7 @@ var TransitionGroup = function (_React$Component) {
if (currentChildMapping && currentChildMapping.hasOwnProperty(key)) {
// This entered again before it fully left. Add it again.
_this.performEnter(key);
} else {
} else if (component) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this component isn't the TransitionGroup instance. The error would be related to TransitionGroup not being mounted when setState is called, it'd be better to check if the current component is mounted

_this.setState(function (state) {
var newChildren = Object.assign({}, state.children);
delete newChildren[key];
Expand Down
2 changes: 1 addition & 1 deletion src/TransitionGroup.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ class TransitionGroup extends React.Component {
if (currentChildMapping && currentChildMapping.hasOwnProperty(key)) {
// This entered again before it fully left. Add it again.
this.performEnter(key);
} else {
} else if (component) {
this.setState((state) => {
let newChildren = Object.assign({}, state.children);
delete newChildren[key];
Expand Down