Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bengali language for react docs #266

Merged
merged 36 commits into from
Apr 29, 2023
Merged

Conversation

moshfiqrony
Copy link
Contributor

@moshfiqrony moshfiqrony commented Apr 25, 2023

I have been working as a software engineer for last 6 years. I have started using React since my first project in my organization.

I have added two more maintainer and both have 3+ years of working experience in React. One of them is currently a Lecturer at IUBAT - International University of Business Agriculture and Technology.

We are based at Bangladesh and we want to create a Bengali version of React docs for the better understanding of the Bengali native language people.

We also have @nomandhoni-cs @shakib609 @nutboltu in the group. They worked on the legacy doc translation for Bengali.

Maintainers: [ @moshfiqrony, @ahmmedabir9, @nazir021, @nomandhoni-cs, @shakib609, @nutboltu, @ahnafyy, @nafistiham ]

I have been working as a software engineer for last 6 years. I have started using React since my first project in my organization.

I have added two more maintainer and both have 3+ years of working experience in React. One of them is currently a Lecture at International university of business agriculture and technology.

We are based at Bangladesh and we want to create a Bangla version of React docs for the better understanding of the Bangla native language people.
@moshfiqrony moshfiqrony requested a review from tesseralis as a code owner April 25, 2023 09:36
@vercel
Copy link

vercel bot commented Apr 25, 2023

@moshfiqrony is attempting to deploy a commit to the Meta Open Source Team on Vercel.

A member of the Team first needs to authorize it.

@nomandhoni-cs
Copy link

@moshfiqrony Please Add me, I used to work in the last react.org docs for translation.

@moshfiqrony
Copy link
Contributor Author

Thank you so much @nomandhoni-cs for your interest. Can you share your previous PR link here?

@nomandhoni-cs
Copy link

@moshfiqrony After making some progress, React Moved their docs from React.org to React.dev

I am pretty much involved with Open Source, as you can see from my GitHub profile.

Merged:
stale-reactjs-org-translations/bn.reactjs.org#215
stale-reactjs-org-translations/bn.reactjs.org#216

Not Merged:
stale-reactjs-org-translations/bn.reactjs.org#214
stale-reactjs-org-translations/bn.reactjs.org#213
stale-reactjs-org-translations/bn.reactjs.org#205

@moshfiqrony
Copy link
Contributor Author

I really appreciate the effort. Thanks for sharing the links. I will add you.

@nomandhoni-cs
Copy link

Thank you! It means a lot to me. I hope this is gonna be an amazing journey

@moshfiqrony
Copy link
Contributor Author

@nomandhoni-cs Just wanted to make sure you already saw this Maintainer responsibilities. If not I would encourage you to have a look at this and let me know you are ok with it.

@nomandhoni-cs
Copy link

Yup! I already read the Maintainer responsibilities.

@nomandhoni-cs
Copy link

I am familiar with this culture of making PR and merging things! And I want to get this maintainer experience and maintain the project.

@nomandhoni-cs
Copy link

Maintainer responsibilities are almost same as previous react.org docs Maintainer responsibilities. So, I am confortable with the responsibilities

@moshfiqrony moshfiqrony changed the title Add Bangla translation for react docs Add Bangla language for react docs Apr 26, 2023
@nomandhoni-cs
Copy link

Thanks, hope this PR gets merged!

@moshfiqrony moshfiqrony changed the title Add Bangla language for react docs Add Bengali language for react docs Apr 26, 2023
@moshfiqrony moshfiqrony mentioned this pull request Apr 26, 2023
@shakib609
Copy link
Member

shakib609 commented Apr 26, 2023

Hello @moshfiqrony

Continuing from #277

Great that you took the initiative to add Bengali translations for the new website. me and some other developers from the community have been maintaining the previous react translations. Would love to start translating the new version as well.

Can you kindly add me as well to the maintainers list?

You can check my previous translation PRs here.
Also, I have reviewed many PRs merged to the legacy React docs as well.

Looking forward to starting the new translations.

@ahnafyy
Copy link

ahnafyy commented Apr 26, 2023

Came here from link @moshfiqrony please add me as well as contributor!

p.s. @shakib609 would also like to be added

langs/bn.json Outdated Show resolved Hide resolved
langs/bn.json Outdated Show resolved Hide resolved
@nutboltu
Copy link
Member

@moshfiqrony Thanks for taking the initiative for the new translation.

I would be happy to be a part of the new journey. However, I am sharing my learnings from my previous experience:

  1. It would be good to maintain a Glossary from the beginning.
  2. We can set some rules for Bengali translations only. e.g
    • There shouldn't be any mixture of English and Bengali languages while translating a sentence.
    • Technical keywords shouldn't be translated.
    • A significant page can be breakdown into multiple PRs. It will help the volunteers to translate and keep updated with the changes.
  3. A Slack/Discord channel for the maintainers will significantly help in further discussions.
  4. Some PRs from the root repositories will require translations and fixing merge conflicts. Setting up a weekly reminder for the maintainers would help address those PRs. Otherwise, the entire translation would need to be updated.

@ahnafyy
Copy link

ahnafyy commented Apr 26, 2023

@moshfiqrony Thanks for taking the initiative for the new translation.

I would be happy to be a part of the new journey. However, I am sharing my learnings from my previous experience:

  1. It would be good to maintain a Glossary from the beginning.

  2. We can set some rules for Bengali translations only. e.g

    • There shouldn't be any mixture of English and Bengali languages while translating a sentence.
    • Technical keywords shouldn't be translated.
    • A significant page can be breakdown into multiple PRs. It will help the volunteers to translate and keep updated with the changes.
  3. A Slack/Discord channel for the maintainers will significantly help in further discussions.

  4. Some PRs from the root repositories will require translations and fixing merge conflicts. Setting up a weekly reminder for the maintainers would help address those PRs. Otherwise, the entire translation would need to be updated.

  1. Glossary sounds like a fantastic idea! Good call, man. Lets do it 🕺
  2. No mixture alright alright.. I see your point but can one write a sentence in bengali but keep the technical word still in english?
  3. All in for slack/discord! Lets make it.
  4. Lets setup a weekend day? Maybe around bangladesh night time and US morning time? 😄

@nutboltu
Copy link
Member

nutboltu commented Apr 26, 2023

@ahnafyy

No mixture alright alright.. I see your point but can one write a sentence in bengali but keep the technical word still in English?

IMO, we can keep the Technical keywords unchanged. (e.g.: React, Javascript, HTML, CSS). But this decision should come from all the maintainers

@moshfiqrony
Copy link
Contributor Author

@nutboltu that makes total sense. Let's continue it once the pr gets merged and the repo gets created. I have plan for Discord server for communication.

@tesseralis @gaearon Do we need to provide any more information to get this started?

@nafistiham
Copy link

@moshfiqrony, I would like to join as a maintainer. I tried contributing to react bn 4 years back Farhad Yasir vai did approve my works but unfortunately, I was a novice in using git back then and the branches got mixed up. Now I'd like to start anew.

I have more than 4 years of professional experience. Currently, I am working as a senior engineer at bKash. I have had more than 2 years of experience using React in my last workplace. I'd like to add that I have authored a book on mathematics, half of which is rigorous translated work.

I have read and understood the responsibilities. I aim to adhere to them to the best of my capability.

@moshfiqrony
Copy link
Contributor Author

@nutboltu @shakib609 @nomandhoni-cs @ahnafyy what can be the criteria to make someone maintainer? What are your thoughts for @nafistiham. We are not judging him. Just as an example.

@ahnafyy
Copy link

ahnafyy commented Apr 27, 2023

My suggestions (i.e. opinions)

  • We would like people who are familiar with actually working with react/ javascript/ know how the DOM works and have 3-4 years of experience working with it.

Reason: If not, you'll often be confused when the doc will talk about something fairly technical. If you don't truly understand what it's saying clearly you won't be able to translate it a way that remains true to its essence.

  • We would like people who are actively working on it!

Reason: If not, what's the point of you being a maintainer? I am also suggesting if there are people who contribute a lot, we think about swapping them with a different person who is a maintainer and is a little inactive.

  • We would like people who speak bengali and have experience translating (or skilled enough to do it!)

Reason: If you dont know how to do it haha wait what? how are you doing this? dont you dare say chatGPT or google translate lmao 🤡

Last thought,
I say lets keep 4-5 maintainers max at first 👥
We can swap people in and out like have a rotation if someone is being like I am going to be inactive for a bit or is wanting to move on to give someone else a chance to contribute more (or are inactive?) If you're not a maintainer when this PR gets merged that don't mean you won't be able to contribute (or even be one in the future) 😄

gaearon and others added 25 commits April 29, 2023 10:20
As discussed in reactjs/fa.react.dev#328
link: reactjs/fa.react.dev#328
title: New Persian Translation Progress
* Simplify translation infra

Co-authored-by: Nat Alison <tesseralis@gmail.com>
Co-authored-by: Brian Vaughn <brian.david.vaughn@gmail.com>

* Add a local create-translation workflow

---------

Co-authored-by: Nat Alison <tesseralis@gmail.com>
Co-authored-by: Brian Vaughn <brian.david.vaughn@gmail.com>
Hi, this minor change helps UX. when the mouse is on the sort options, it visually hints the user what their mouse pointing at is a functional filtering option
@moshfiqrony
Copy link
Contributor Author

moshfiqrony commented Apr 29, 2023

As a part of fixing the permission sync process, we've changed how we track languages — please see 63a10c4.
Could you please update this PR:

  • Rebase on top of latest main, and add the language to lang/langs.json instead
  • Include the list of maintainers into the PR comment body instead

Thank you, and sorry for the churn.

Thanks for the feedback @gaearon. PR Updated based on the suggestion.

Just confirming

  • I can see langs/langs.json not lang/langs.json what you mentioned

@gaearon gaearon merged commit e76c125 into reactjs:main Apr 29, 2023
@gaearon
Copy link
Member

gaearon commented Apr 29, 2023

reactjs/bn.react.dev#1

@moshfiqrony
Copy link
Contributor Author

Thank you so much @gaearon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.