Simplify the translation infra #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Nat Alison <tesseralis@gmail.com> Co-authored-by: Brian Vaughn <brian.david.vaughn@gmail.com>
This was referenced Apr 29, 2023
moshfiqrony
pushed a commit
to moshfiqrony/translations.react.dev
that referenced
this pull request
Apr 29, 2023
* Simplify translation infra Co-authored-by: Nat Alison <tesseralis@gmail.com> Co-authored-by: Brian Vaughn <brian.david.vaughn@gmail.com> * Add a local create-translation workflow --------- Co-authored-by: Nat Alison <tesseralis@gmail.com> Co-authored-by: Brian Vaughn <brian.david.vaughn@gmail.com>
gaearon
added a commit
that referenced
this pull request
Apr 29, 2023
* Add Bangla translation for react docs I have been working as a software engineer for last 6 years. I have started using React since my first project in my organization. I have added two more maintainer and both have 3+ years of working experience in React. One of them is currently a Lecture at International university of business agriculture and technology. We are based at Bangladesh and we want to create a Bangla version of React docs for the better understanding of the Bangla native language people. * Added the nomandhoni-cs as maintainer * Added shakib609 and ahnafyy as maintainer * Added nutboltu as maintainer * Update pl.json (#272) * First-pass update to the FR maintainers (#271) We're in the process of waking up the legacy crew, that had 10+ people contributing significantly (and many more doing small contributions). This is who we can expect lots of work from on the new docs so far. * Update PROGRESS.template.md * Update it.json * Update ar.json to match repo settings * Update fa.json to match repo settings * Remove language that was never deployed * Update he.json to match repo settings * Update uk.json to match repo settings * Update vi.json to match the repo settings * Update zh-hans.json to match repo settings * Update zh-hant.json to match repo settings * Stop spamming comments * Delete CODEOWNERS * Remove test files * Move stuff around * Update fa maintainers (#273) As discussed in reactjs/fa.react.dev#328 link: reactjs/fa.react.dev#328 title: New Persian Translation Progress * Update zh-hant.json to match the current list According to reactjs/zh-hant.react.dev#260 (comment). * Simplify the translation infra (#285) * Simplify translation infra Co-authored-by: Nat Alison <tesseralis@gmail.com> Co-authored-by: Brian Vaughn <brian.david.vaughn@gmail.com> * Add a local create-translation workflow --------- Co-authored-by: Nat Alison <tesseralis@gmail.com> Co-authored-by: Brian Vaughn <brian.david.vaughn@gmail.com> * Tweak wording * Add fi, lo, and sw translations (#286) * Update engines * Allow manually running workflows * Try to run stuff * Cursor is now a pointer when mouse is on sort options (#284) Hi, this minor change helps UX. when the mouse is on the sort options, it visually hints the user what their mouse pointing at is a functional filtering option * Add Icelandic (#270) * Oops * Don't fail on existing sync PRs * Removed bn.json file * Added Bengali translation entry * Update langs.json --------- Co-authored-by: dan <dan.abramov@me.com> Co-authored-by: Christophe Porteneuve <tdd@tddsworld.com> Co-authored-by: Alessandro De Blasis <alex@deblasis.net> Co-authored-by: Dan Abramov <dan.abramov@gmail.com> Co-authored-by: Sajjad Khodadadi <sajjad.khddd@gmail.com> Co-authored-by: Nat Alison <tesseralis@gmail.com> Co-authored-by: Brian Vaughn <brian.david.vaughn@gmail.com> Co-authored-by: Abolfazl Chaman <88617114+abolfazlchaman@users.noreply.github.com> Co-authored-by: Haukur Páll Hallvarðsson <hph@hph.is>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the beginning, this repository used to house two kinds of scripts:
What are we fixing
It turns out, we stopped running the permission sync a long time ago. When we thought we fixed it a few years ago, we only fixed the content script (and moved it to another repository). So this is why, for example, maintainer lists weren't getting updated, and the Finnish repository was never created despite the pull request getting merged. And then we didn't notice that due to the Finnish repository missing, the French site has stopped getting synced (because the Finnish repo being missing crashed the entire batch around it).
This is all to say — the stuff has been broken for a while, and I want to reorganize it in a way that's less fragile.
What are we doing instead
In this PR, I move the content script back into this repo. This is where its GitHub Actions will run from. This will make the content sync process visible. I think I fixed the bug where one language failing fails the entire batch.
I am completely removing permission syncing script. We won't track maintainers in a repo at all anymore. Instead, we'll flatten the existing localization GitHub Teams directly as Admins of the corresponding repos. The Teams feature isn't particularly useful for us anyway. This fixes the issue where many repos have diverged, adding some members directly and some via a team. Previously, we thought we'd use Teams for communication, but GH is migrating that to Discussions anyway.
However, I'm keeping the "create a new translation repo" script. This now sets up both the repo and the Vercel project. You have to pass the initial maintainers, and you can only do this after merging a corresponding pull request that edits
langs/langs.json. Here's how to run it. Note that this script can only be run locally by someone with access to the org: