This repository has been archived by the owner on Oct 6, 2023. It is now read-only.
feat: switch buffer to native Uint8Array #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erunion
requested review from
a team,
Dashron and
julshotal
and removed request for
a team
Dashron
approved these changes
Oct 15, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 What's being changed?
Since our
style-serializerlibrary is forked fromswagger-jsthis pulls a recent change they made upstream in swagger-api/swagger-js#2288 down to us.🧬 Testing
Since
TextEncoderdoesn't exist in IE, Webpack will automatically polyfill that like it did with the Nodebufferthat we were pulling in. Main difference with this change is that that polyfill, and the resulting Webpack generated dist, will be much smaller now.That said, if tests still pass here we're good.