Implementation of new notification system #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
This temporal hack allows us to show the new notifications from Django templates. The next step here is to implement the notifications properly using Knockout and keep this feature on.
agjohnson
reviewed
Jan 3, 2024
|
I opened up #259 to discuss next steps and full support of the new notifications. |
Render new `Notification` if there are any. Otherwise, render `Build.error`.
|
This is ready to be merged as v1 at least. It's not perfect, but will give us parity with the old dashboard for now at least. |
agjohnson
approved these changes
Jan 4, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial work on the ext-theme.
Reference: readthedocs/readthedocs.org#10922