Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementation of new notification system #254

Merged
merged 11 commits into from
Jan 4, 2024
Merged

Implementation of new notification system #254

merged 11 commits into from
Jan 4, 2024

Commits on Dec 19, 2023

  1. Initial comment

    @humitos
    humitos committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    bed8800 View commit details
    Browse the repository at this point in the history

  2. Show new notifications statically via Django templates

    @humitos
    humitos committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    de27f3f View commit details
    Browse the repository at this point in the history

  3. Refresh the page once the build has finished 

    This temporal hack allows us to show the new notifications from Django
templates. The next step here is to implement the notifications properly using
Knockout and keep this feature on.
    @humitos
    humitos committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    7f8837f View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2023

  1. Merge branch 'main' into humitos/new-notification-system

    @humitos
    humitos authored Dec 21, 2023
    Configuration menu
    Copy the full SHA
    991db5f View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2024

  1. Keep rendering old Build.error 

    Render new `Notification` if there are any. Otherwise, render `Build.error`.
    @humitos
    humitos committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    dedf675 View commit details
    Browse the repository at this point in the history

  2. Iterate over the right element

    @humitos
    humitos committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    13557e9 View commit details
    Browse the repository at this point in the history

  3. Remove debugging

    @humitos
    humitos committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    8cf2ab1 View commit details
    Browse the repository at this point in the history

  4. Lint

    @humitos
    humitos committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    b20682f View commit details
    Browse the repository at this point in the history

  5. Remove rendering for django-messages-extends 

    Related readthedocs/readthedocs.org#10994
    @humitos
    humitos committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    be09519 View commit details
    Browse the repository at this point in the history

  6. Remove invalid comment

    @humitos
    humitos committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    8e82fb0 View commit details
    Browse the repository at this point in the history

  7. Build assets

    @humitos
    humitos committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    832841a View commit details
    Browse the repository at this point in the history