Remove comments builder #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The CSS classes have the sphinx prefix |
stsewd
commented
Apr 5, 2018
| }) | ||
|
|
There was a problem hiding this comment.
All this file can be removed, I suppose. But the lib/settings.js was required by the others libs, so it was included in the bundle. Settings.js have information that is used outside the comments builder?
There was a problem hiding this comment.
Also, we need to re-minify the js (css too?) after the PR is completed.
|
I think this PR wasn't ready to be merged, there were some decisions to be made |
|
|
Ok, I'll continue with this on other PR, also try to test this with my rtd instance |
This was referenced Apr 27, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR on top of #31
Related PR: readthedocs/readthedocs.org#3802
What is missing?