Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove comments builder #38

Merged
merged 4 commits into from
Apr 26, 2018
Merged

Remove comments builder #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4f76042
Remove comments integration from live RTD.
ericholscher Dec 12, 2017
e44ff7a
Update .gitignore
stsewd Apr 5, 2018
24256cf
Remove comments folder
stsewd Apr 5, 2018
35fc71a
Remove JS for comments
stsewd Apr 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,5 @@ build
dist
wheelhouse
.tox
.python-version
.pytest_cache/
9 changes: 0 additions & 9 deletions readthedocs_ext/_static/javascript/client.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,2 @@
comm = require('./lib/comm')
events = require('./lib/events')
display = require('./lib/display')

$(document).ready(function () {
events.initEvents();
comm.initOptions();
comm.initMetaData();
display.initDisplay();
})

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All this file can be removed, I suppose. But the lib/settings.js was required by the others libs, so it was included in the bundle. Settings.js have information that is used outside the comments builder?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, we need to re-minify the js (css too?) after the PR is completed.

197 changes: 0 additions & 197 deletions readthedocs_ext/_static/javascript/lib/comm.js
View file
Open in desktop

This file was deleted.

141 changes: 0 additions & 141 deletions readthedocs_ext/_static/javascript/lib/display.js
View file
Open in desktop

This file was deleted.

27 changes: 0 additions & 27 deletions readthedocs_ext/_static/javascript/lib/events.js
View file
Open in desktop

This file was deleted.

Loading