Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pip --only-binary=:all: option is not an exact replacement of --use-wheels #4262

Closed
humitos opened this issue Jun 18, 2018 · 2 comments
Closed
Labels
Needed: design decision A core team decision is required

Comments

@humitos
Copy link
Member

humitos commented Jun 18, 2018

On today's deploy we found that mock==1.0.1 is not installable with --only-binary=:all: option but it was installable with the --use-wheels.

I tested this locally before deploying but it did work in my instance, so I was probably using a different version of pip or something like that. We are using pip 9.0.1 in production.

We need to keep discussing this.

For now, we revert the PR #4206 that introduces this change.
Revert PR at #4261

@humitos humitos added the Needed: design decision A core team decision is required label Jun 18, 2018
@humitos humitos added this to the Build stability milestone Jun 18, 2018
@humitos
Copy link
Member Author

humitos commented Jun 18, 2018

It seems like --use-wheels was like prefer wheels instead of force them. I think that maybe new pip versions do that by default and no option is needed.

@stsewd
Copy link
Member

stsewd commented Jun 19, 2018

Ok, I couldn't find the changelog for this, but I found this in the docs

Pip prefers Wheels where they are available. To disable this, use the --no-binary flag for pip install.

If no satisfactory wheels are found, pip will default to finding source archives.

https://pip.pypa.io/en/stable/user_guide/#installing-from-wheels

So, we only need is to remove that option :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needed: design decision A core team decision is required
Projects
None yet
Development

No branches or pull requests

2 participants