Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Merge pull request #4206 from FlorianKuckelkorn/fix/pip-breaking-change" #4261

Merged
merged 1 commit into from
Jun 19, 2018
Merged

Revert "Merge pull request #4206 from FlorianKuckelkorn/fix/pip-breaking-change" #4261

merged 1 commit into from
Jun 19, 2018

Conversation

agjohnson
Copy link
Contributor

This reverts commit b6de0c4, reversing
changes made to 08beab1.

Ref #4206

This breaks because packages with no binary fail to install. This doesn't seem
to be the functionality that we want. --use-wheel used a wheel and backed
down to source packages

@agjohnson
Revert "Merge pull request #4206 from FlorianKuckelkorn/fix/pip-break…
4fec032 
…ing-change"

This reverts commit b6de0c4, reversing
changes made to 08beab1.
@agjohnson agjohnson requested a review from a team June 18, 2018 22:11
@agjohnson agjohnson added the PR: hotfix Pull request applied as hotfix to release label Jun 18, 2018
@agjohnson
Copy link
Contributor Author

The underlying change should go back to design decision.

@humitos humitos mentioned this pull request Jun 18, 2018
Closed
@stsewd stsewd mentioned this pull request Jun 19, 2018
Closed
ericholscher
ericholscher reviewed Jun 19, 2018
View reviewed changes
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we can just remove this line, and newer pip will use the wheel if it exists. I should have tested this fix better locally :(

@humitos
Copy link
Member

humitos commented Jun 19, 2018

Agree. Santos found this #4262 (comment)

I think we should just remove that option and we will be safe.

@ericholscher
Copy link
Member

Merging this, but agreed we should open another removing it.

@ericholscher ericholscher merged commit 017f581 into master Jun 19, 2018
@ericholscher
Copy link
Member

Opened #4269

@agjohnson agjohnson deleted the agj/hotfix-pip10 branch June 20, 2018 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericholscher ericholscher ericholscher left review comments

Assignees
No one assigned
Labels
PR: hotfix Pull request applied as hotfix to release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@agjohnson @humitos @ericholscher