Do not have a separate background for ads #3625
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- If we do want to have a separate background for ads I would say we should be systematic about it. - Also, this makes it harder to build an ad for more themes
|
Seems reasonable. I do think this was done to make the ad feel separate from the content. Is the reason we don't want it because it's harder to port, or some other reason? |
|
I'm trying to reduce theme specific stuff and especially stuff that is somewhat inconsistent. |
|
I'm impartial on removing these styles, but I do prefer the background color for differentiation on our theme and on alabaster. The changes here look fine if this is a change we need to make though. |
|
This changed anyway with the rework for the Ads API #3747. This can be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we do want to have a separate background for ads I would say we should be systematic about it. Also, this makes it harder to build an ad for more themes.
BEFORE
AFTER
