Use sustainability api for advertising #3747
Conversation
|
Hmm. This is hard to review because of the file rename. Is there a good way to see the logic changes as a diff? |
|
Looking at it, I guess it's a totally different pattern, so ignore me :) |
There was a problem hiding this comment.
This looks like a really nice pattern to follow. It should also allow us to trivially document an explicit div_id where users would want us to inject things, in order to actually build that logic into the themes and other bits going forward.
A few small nits, but overall I really like this pattern. Would be good to get @agjohnson to take a look as well, since he has more context around the JS & CSS bits.
| post_data.placements = get_placements(rtd); | ||
| post_data.project = rtd.project; | ||
|
|
||
| if (typeof URL !== 'undefined' && typeof URLSearchParams !== 'undefined') { |
There was a problem hiding this comment.
Where do these variables come from? They look like new JS things that will not work on older browsers? https://developer.mozilla.org/en-US/docs/Web/API/URLSearchParams
There was a problem hiding this comment.
That is correct. They will not. Hence the typeof checking. Old browsers will not be able to force a specific promo or campaign. However, with the typeof checking they will not trigger errors.
There was a problem hiding this comment.
Gotcha. I do worry about using newer browser features for something whose primary purpose is linking to others, because it might break on their browser. We can change it if it becomes an issue though.
There was a problem hiding this comment.
Unfortunately reading GET params without these builtins or adding a purpose built library becomes somewhat non-trivial.
There was a problem hiding this comment.
URLSearchParams is supported everywhere but older IE/Edge versions. This is ~3% of our traffic overall. I did verify this code path on IE11 to make sure there isn't an issue.
| if (typeof URL !== 'undefined' && typeof URLSearchParams !== 'undefined') { | ||
| // Force a specific promo to be displayed | ||
| params = new URL(window.location).searchParams; | ||
| force = params.get('promo'); |
There was a problem hiding this comment.
Could use a better variable name here, this reads like a boolean. Perhaps explicit_promo or forced_promo
| } | ||
|
|
||
| // Force a promo from a specific campaign | ||
| force = params.get('campaign'); |
There was a problem hiding this comment.
Similar, shouldn't repeat the variable name, should use something explicit.
|
I made the changes based on initial feedback. |
This updates our front-end advertising code to use the new sustainability API for advertising decisions.
NOTE: This is built off of #3672. If this is merged, that one can be closed.