Don't use RequestsContext

[stsewd]

This is kind of deprecated on django 1.11 https://docs.djangoproject.com/en/2.1/releases/1.11/#django-template-backends-django-template-render-prohibits-non-dict-context

The solution s compatible with older versions

Ref #4750

[humitos]

Good catch!

This is ready to merge.

This is something that a simple test case for any of this views would have caught. Don't we have a test case for this? If no, do you want to write tests for creating/editing the profiles?

[stsewd]

I think we don't have tests for this, we only have a couple of tests for the forms, not the views. I'll check the coverage

[stsewd]

Well, we have only 20% coverage here p:

[stsewd]

I'm writing some tests for this, but @davidfischer feel free to merge this if you need to keep going with the django upgrade. I think there are some bugs on the views and it will take some time

[davidfischer]

I don't think there's a huge rush although the Django upgrade is pretty high up my priority list. You have plenty of time to write tests.

[stsewd]

And we have 98% coverage on profiles/view.py now :)

I also deleted an unused view (create_profile), I tested with a new user and we don't use it, also it wasn't working before https://readthedocs.org/accounts/create/ anyway.

[stsewd]

Let me know if we still need create_profile to put it back again and fix the bug

[stsewd]

Here was a bug, it should be profiles_profile_edit

[humitos]

Let me know if we still need create_profile to put it back again and fix the bug

I grepped all the repositories and I didn't find that it's used in any place. I think we are safe removing it.

[humitos]

@ericholscher I think we can merge this one, can you confirm that the method removed is not needed and it's OK by removing it?

[ericholscher]

Yep. I think we should probably just get rid of profiles here at some point, since they are barely used. It's actually a vendoring of the old django-profiles app.