Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use RequestsContext #4759

Merged
merged 3 commits into from
Oct 23, 2018
Merged

Don't use RequestsContext #4759

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
be9e74b
Don't use RequestsContext
stsewd Oct 15, 2018
fa2ed8a
Delete unused code
stsewd Oct 16, 2018
46fb585
Tests
stsewd Oct 16, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 12 additions & 13 deletions readthedocs/profiles/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
from django.core.urlresolvers import reverse
from django.http import Http404, HttpResponseRedirect
from django.shortcuts import get_object_or_404, redirect, render
from django.template.context import RequestContext
from django.utils.translation import ugettext_lazy as _

from readthedocs.core.forms import UserDeleteForm, UserAdvertisingForm
Expand Down Expand Up @@ -101,10 +100,10 @@ def create_profile(

if extra_context is None:
extra_context = {}
context = RequestContext(request)
for key, value in list(extra_context.items()):
context[key] = (value() if callable(value) else value)

context = {
key: value() if callable(value) else value
for key, value in extra_context.items()
}
context.update({'form': form})
return render(request, template_name, context=context)

Expand Down Expand Up @@ -180,10 +179,10 @@ def edit_profile(

if extra_context is None:
extra_context = {}
context = RequestContext(request)
for key, value in list(extra_context.items()):
context[key] = (value() if callable(value) else value)

context = {
key: value() if callable(value) else value
for key, value in extra_context.items()
}
context.update({
'form': form,
'profile': profile_obj,
Expand Down Expand Up @@ -274,10 +273,10 @@ def profile_detail(

if extra_context is None:
extra_context = {}
context = RequestContext(request)
for key, value in list(extra_context.items()):
context[key] = (value() if callable(value) else value)

context = {
key: value() if callable(value) else value
for key, value in extra_context.items()
}
context.update({'profile': profile_obj})
return render(request, template_name, context=context)

Expand Down