[C] Windows fixes #861
Merged
[C] Windows fixes #861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The buffer needs to be freed with LocalFree - Check the result of FormatMessageA - Use %s in case the error message contains a % character
aeron_unmap: - UnmapViewOfFile returns a nonzero value on success aeron_is_directory: - Check for file attributes as flags - GetFileAttributes can return INVALID_FILE_ATTRIBUTES on error
- It's not used anywhere, aeron_cmpxchg64 is used instead - The MSVC definition used GCC syntax so wouldn't compile if used
mjpt777
reviewed
Feb 19, 2020
| @@ -168,8 +168,14 @@ void aeron_set_windows_error() | |||
| 0, | |||
| NULL); | |||
|
|
|||
| aeron_set_err(errorId, messageBuffer); | |||
| free(messageBuffer); | |||
| if (result == 0) | |||
There was a problem hiding this comment.
Formatting is a bit screwed here. Is there something missing?
There was a problem hiding this comment.
Sorry, I inserted tabs here instead of spaces, will fix.
mjpt777
reviewed
Feb 19, 2020
| @@ -64,16 +64,6 @@ do \ | |||
| } \ | |||
| while (false) | |||
|
|
|||
| #define AERON_CMPXCHG64(original, dst, expected, desired) \ | |||
There was a problem hiding this comment.
- It's not used anywhere,
aeron_cmpxchg64is used instead - The MSVC definition used GCC syntax so wouldn't compile if used
mjpt777
reviewed
Feb 19, 2020
| @@ -226,7 +226,7 @@ int aeron_udp_channel_transport_init( | |||
| if(set_socket_non_blocking(transport->fd) < 0) | |||
There was a problem hiding this comment.
Minor point on formatting here. No space after if.
There was a problem hiding this comment.
Ok, I'll fix that in the next PR I see you've fixed it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's another round of Windows fixes for the media driver. See individual commit messages for details. The cleanup commit mostly gets rid of some warnings and makes the IDE happier.
There are still other things I'll need to fix though, I'll send the fixes later.