Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C] Windows fixes #861

Merged
merged 6 commits into from
Feb 19, 2020
Merged

[C] Windows fixes #861

merged 6 commits into from
Feb 19, 2020

Commits on Feb 18, 2020

  1. [C] Fix aeron_set_windows_error 

     - The buffer needs to be freed with LocalFree
 - Check the result of FormatMessageA
 - Use %s in case the error message contains a % character
    @ltrzesniewski
    ltrzesniewski committed Feb 18, 2020
    Configuration menu
    Copy the full SHA
    0078720 View commit details
    Browse the repository at this point in the history

  2. [C] Fix file operations on Windows 

    aeron_unmap:
 - UnmapViewOfFile returns a nonzero value on success

aeron_is_directory:
 - Check for file attributes as flags
 - GetFileAttributes can return INVALID_FILE_ATTRIBUTES on error
    @ltrzesniewski
    ltrzesniewski committed Feb 18, 2020
    Configuration menu
    Copy the full SHA
    a92804f View commit details
    Browse the repository at this point in the history

  3. [C] The forward slash is also a valid path separator on Windows

    @ltrzesniewski
    ltrzesniewski committed Feb 18, 2020
    Configuration menu
    Copy the full SHA
    c79da14 View commit details
    Browse the repository at this point in the history

  4. [C] Remove AERON_CMPXCHG64 

     - It's not used anywhere, aeron_cmpxchg64 is used instead
 - The MSVC definition used GCC syntax so wouldn't compile if used
    @ltrzesniewski
    ltrzesniewski committed Feb 18, 2020
    Configuration menu
    Copy the full SHA
    a983f23 View commit details
    Browse the repository at this point in the history

  5. [C] Various cleanup

    @ltrzesniewski
    ltrzesniewski committed Feb 18, 2020
    Configuration menu
    Copy the full SHA
    7c9ae2d View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2020

  1. [C] Fix tabs and whitespace

    @ltrzesniewski
    ltrzesniewski committed Feb 19, 2020
    Configuration menu
    Copy the full SHA
    791a5f2 View commit details
    Browse the repository at this point in the history