-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Header slugs incompatible with GitHub-Flavored Markdown #524
Comments
@segiddins wrote that code in #84 when we migrated to redcarpet for Markdown rendering. Sam, do you remember why you went with underscores here? It seems to me that updating this to use dashes would be fine given the predominance of GitHub-hosted projects. I have no clue how many people use one over the other in the wild either. |
I think it was just arbitrary |
Cool, not a bad choice initially, but in light of @zwaldowski's evidence, I vote we change the |
/me rolls for an Intelligence check |
GitHub-Flavored Markdown slugs headers using dashes (
-
), not underscores (_
), rendering anchor links for READMEs invalid in Jazzy when they are valid online, i.e., when generated with doctoc.I'd PR to fix it myself, but I'm not sure what breakages would occur and/or why the dash was chosen.
Cheers!
The text was updated successfully, but these errors were encountered: