Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header slugs incompatible with GitHub-Flavored Markdown #524

Closed
zwaldowski opened this issue Apr 13, 2016 · 4 comments
Closed

Header slugs incompatible with GitHub-Flavored Markdown #524

zwaldowski opened this issue Apr 13, 2016 · 4 comments

Comments

@zwaldowski
Copy link
Contributor

GitHub-Flavored Markdown slugs headers using dashes (-), not underscores (_), rendering anchor links for READMEs invalid in Jazzy when they are valid online, i.e., when generated with doctoc.

I'd PR to fix it myself, but I'm not sure what breakages would occur and/or why the dash was chosen.

Cheers!

@jpsim
Copy link
Collaborator

jpsim commented Apr 14, 2016

@segiddins wrote that code in #84 when we migrated to redcarpet for Markdown rendering. Sam, do you remember why you went with underscores here?

It seems to me that updating this to use dashes would be fine given the predominance of GitHub-hosted projects. I have no clue how many people use one over the other in the wild either.

@segiddins
Copy link
Collaborator

I think it was just arbitrary

@jpsim
Copy link
Collaborator

jpsim commented Apr 14, 2016

Cool, not a bad choice initially, but in light of @zwaldowski's evidence, I vote we change the _ for a -. @zwaldowski care to do this?

@zwaldowski
Copy link
Contributor Author

/me rolls for an Intelligence check

zwaldowski added a commit to zwaldowski/jazzy that referenced this issue Apr 14, 2016
zwaldowski added a commit to zwaldowski/jazzy that referenced this issue Apr 14, 2016
zwaldowski added a commit to zwaldowski/jazzy that referenced this issue Apr 14, 2016
@jpsim jpsim closed this as completed Apr 22, 2016
lumaxis pushed a commit to bitstadium/jazzy that referenced this issue May 4, 2016
@pigeondotdev pigeondotdev modified the milestone: The Past Nov 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants