Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use - for Markdown slugs instead of _ #526

Merged
merged 1 commit into from
Apr 14, 2016

Conversation

zwaldowski
Copy link
Contributor

See #524.

Requires spec updates. Workin' on it…

zwaldowski added a commit to zwaldowski/jazzy-integration-specs that referenced this pull request Apr 14, 2016
@zwaldowski zwaldowski force-pushed the zw-dash-readme-links branch from eaa6fd2 to a09996d Compare April 14, 2016 02:06
jpsim added a commit to realm/jazzy-integration-specs that referenced this pull request Apr 14, 2016
@jpsim
Copy link
Collaborator

jpsim commented Apr 14, 2016

Looking good! Please update the integration specs submodule to point to the latest master, CI will run again and then this should be good to merge!


##### Bug Fixes

* Uses GitHub-Flavored Markdown syntax for anchors when rendering README pages.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 trailing spaces on the last line describing the change please. (from https://github.com/realm/jazzy/blob/master/CONTRIBUTING.md)

@zwaldowski zwaldowski force-pushed the zw-dash-readme-links branch from a09996d to f80d5f7 Compare April 14, 2016 03:21
@zwaldowski
Copy link
Contributor Author

Updated! Let 👷 give it the go-ahead!

@jpsim
Copy link
Collaborator

jpsim commented Apr 14, 2016

¡Muy bien!

@jpsim jpsim merged commit 1174112 into realm:master Apr 14, 2016
@zwaldowski zwaldowski deleted the zw-dash-readme-links branch April 14, 2016 04:24
@pigeondotdev pigeondotdev modified the milestone: The Past Nov 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants