Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #429 generic type #698

Merged
merged 4 commits into from
Dec 13, 2016
Merged

Fix #429 generic type #698

merged 4 commits into from
Dec 13, 2016

Conversation

jpsim
Copy link
Collaborator

@jpsim jpsim commented Dec 12, 2016

Continued from #696.

@jpsim jpsim mentioned this pull request Dec 12, 2016
Closed
@jpsim
Copy link
Collaborator Author

jpsim commented Dec 12, 2016

@istx25 since review already happened in #696, the github-review-needs-review label isn't appropriate. I've changed to github-review-accepted.

@pigeondotdev
Copy link
Contributor

Sounds good to me. :)

@jpsim jpsim merged commit 5745ab2 into master Dec 13, 2016
@jpsim jpsim deleted the fix-429-generic-types branch December 13, 2016 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jpsim jpsim

Labels
bug github-review-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jpsim @pigeondotdev @SDGGiesbrecht