Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add User.Changed event #3433

Merged
merged 7 commits into from
Sep 25, 2023
Merged

Add User.Changed event #3433

merged 7 commits into from
Sep 25, 2023

Conversation

nirinchev
Copy link
Member

@nirinchev nirinchev commented Aug 31, 2023 •
edited
Loading

Description

Addresses #3429, but is not a real fix as it only notifies that the user changed, but doesn't tell us what exactly changed. We need realm/realm-core#6516 to achieve more precise notifications.

TODO

  • Changelog entry
  • Tests (if applicable)

@cla-bot cla-bot bot added the cla: yes label Aug 31, 2023
papafe
papafe approved these changes Sep 5, 2023
View reviewed changes
Tests/Realm.Tests/Sync/UserManagementTests.cs Show resolved Hide resolved
Tests/Realm.Tests/Sync/UserManagementTests.cs Outdated Show resolved Hide resolved
papafe
papafe approved these changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@papafe papafe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I just left some minor comments. And obviously it needs the changelog

@nirinchev
CR comments
7af95e2
@nirinchev
Merge branch 'main' into ni/user-changed
576d88f 
* main:
  Migrate to new sync error codes (#3440)
  Starting one cluster per platform on CI (#3426)
  Fix trailing comma when there are no features to analyze (#3438)
  Don’t use KeyValuePair in marshaling because it’s overloaded on UWP (#3435)
@nirinchev
Merge branch 'main' into ni/user-changed
3bd0c79
@nirinchev
Ignore tests temporarily
38dc9b3
@nirinchev
Merge branch 'main' into ni/user-changed
250effb
@nirinchev
Fix using closed SafeHandle in Unbind
3a03844
@coveralls-official
Copy link

Pull Request Test Coverage Report for Build 6299453362

  • 13 of 50 (26.0%) changed or added relevant lines in 6 files are covered.
  • 7 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.4%) to 80.262%
Changes Missing Coverage Covered Lines Changed/Added Lines %
Realm/Realm/Handles/SharedRealmHandle.cs 0 1 0.0%
Realm/Realm/Handles/RealmHandle.cs 0 2 0.0%
Realm/Realm/Sync/User.cs 0 10 0.0%
Realm/Realm/Handles/SyncUserHandle.cs 11 35 31.43%
Files with Coverage Reduction New Missed Lines %
Realm/Realm/Exceptions/RealmException.cs 2 78.95%
Realm/Realm/Handles/SessionHandle.cs 2 84.65%
Realm/Realm/Handles/SubscriptionSetHandle.cs 3 90.7%
Totals Coverage Status
Change from base Build 6248813753: -0.4%
Covered Lines: 6318
Relevant Lines: 7762
💛 - Coveralls

@nirinchev nirinchev merged commit ef0e1c8 into main Sep 25, 2023
63 of 66 checks passed
@nirinchev nirinchev deleted the ni/user-changed branch September 25, 2023 13:36
nirinchev added a commit that referenced this pull request Nov 1, 2023
@nirinchev
Merge branch 'main' into ni/evg-tests
a34e397 
* main:
  Small fixes to source generator (#3466)
  Make websocket error logging exceptionally verbose (#3459)
  Emit errors for collection assignments (#3456)
  Fix docfx source files (#3453)
  Fix typo (#3454)
  Add User.Changed event (#3433)
  Allow customizing json ignore attribute for serialized classes (#3451)
  Update README.md (#3450)
  Fix changelog
  Prepare for vNext (#3444)
  Prepare for 11.5.0 (#3442)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@papafe papafe papafe approved these changes

@fealebenpae fealebenpae fealebenpae approved these changes

Assignees

@nirinchev nirinchev

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nirinchev @fealebenpae @papafe