Small fixes to source generator #3466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nirinchev
approved these changes
Oct 30, 2023
Pull Request Test Coverage Report for Build 6693702570
💛 - Coveralls |
nirinchev
added a commit
that referenced
this pull request
Nov 1, 2023
* main: Small fixes to source generator (#3466) Make websocket error logging exceptionally verbose (#3459) Emit errors for collection assignments (#3456) Fix docfx source files (#3453) Fix typo (#3454) Add User.Changed event (#3433) Allow customizing json ignore attribute for serialized classes (#3451) Update README.md (#3450) Fix changelog Prepare for vNext (#3444) Prepare for 11.5.0 (#3442)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two things:
notfrom the generated code, so it should be possible to use c# 8.0 as the minimum supported version. (most of the changes in the PR are due to this)Fixes #3265
TODO