-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add keypath filtering to notifications #3501
Conversation
This works, and most of the tests are there and passing. It requires still some love though, so this is still a draft. I'll keep the TODO list updated in the PR description. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't looked at the tests yet, but figured I'd add my comments so far and review the rest another time.
Co-authored-by: Nikola Irinchev <irinchev@me.com>
@nirinchev Fixed the final things and added the docs, this should be ready to merge. |
Pull Request Test Coverage Report for Build 7832182965
💛 - Coveralls |
This PR adds support for keypath filtering in notifications
Description
Fixes ##1398
TODO