Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keypath filtering to notifications #3501

Merged
merged 60 commits into from
Feb 9, 2024
Merged

Add keypath filtering to notifications #3501

merged 60 commits into from
Feb 9, 2024

Conversation

papafe
Copy link
Contributor

@papafe papafe commented Jan 19, 2024

This PR adds support for keypath filtering in notifications

Description

Fixes ##1398

TODO

  • Changelog entry
  • Correct documentation
  • Tests for lists/sets/dictionaries notifications
  • Cleaning up internals
  • Try to unify subscriptions path (keypath/full/shallow)

@papafe
Copy link
Contributor Author

papafe commented Jan 19, 2024

This works, and most of the tests are there and passing. It requires still some love though, so this is still a draft. I'll keep the TODO list updated in the PR description.

@papafe papafe requested a review from nirinchev January 26, 2024 13:27
@papafe papafe marked this pull request as ready for review January 26, 2024 13:27
Copy link
Member

@nirinchev nirinchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't looked at the tests yet, but figured I'd add my comments so far and review the rest another time.

Realm/Realm/DatabaseTypes/INotifiable.cs Outdated Show resolved Hide resolved
Realm/Realm/DatabaseTypes/KeyPathCollection.cs Outdated Show resolved Hide resolved
Realm/Realm/DatabaseTypes/KeyPathCollection.cs Outdated Show resolved Hide resolved
Realm/Realm/DatabaseTypes/KeyPathCollection.cs Outdated Show resolved Hide resolved
Realm/Realm/DatabaseTypes/KeyPathCollection.cs Outdated Show resolved Hide resolved
Realm/Realm/Handles/DictionaryHandle.cs Outdated Show resolved Hide resolved
Realm/Realm/Handles/ResultsHandle.cs Outdated Show resolved Hide resolved
Realm/Realm/Handles/SetHandle.cs Outdated Show resolved Hide resolved
wrappers/src/notifications_cs.hpp Outdated Show resolved Hide resolved
wrappers/src/notifications_cs.hpp Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@papafe
Copy link
Contributor Author

papafe commented Feb 7, 2024

@nirinchev Fixed the final things and added the docs, this should be ready to merge.
I tried not to repeat myself in the docs, hopefully it makes sense overall

Copy link

coveralls-official bot commented Feb 8, 2024

Pull Request Test Coverage Report for Build 7832182965

  • 84 of 90 (93.33%) changed or added relevant lines in 10 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.07%) to 80.888%

Changes Missing Coverage Covered Lines Changed/Added Lines %
Realm/Realm/DatabaseTypes/KeyPathCollection.cs 26 32 81.25%
Files with Coverage Reduction New Missed Lines %
Realm/Realm/Helpers/SerializationHelper.cs 1 53.53%
Totals Coverage Status
Change from base Build 7831586820: 0.07%
Covered Lines: 6663
Relevant Lines: 8093

💛 - Coveralls

@papafe papafe merged commit 9495446 into main Feb 9, 2024
67 of 68 checks passed
@papafe papafe deleted the fp/keypath-filtering branch February 9, 2024 10:34
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants