Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposed delegate change #3512

Merged
merged 1 commit into from
Feb 7, 2024
Merged

Conversation

nirinchev
Copy link
Member

Description

Fixes #

TODO

  • Changelog entry
  • Tests (if applicable)

Copy link

Pull Request Test Coverage Report for Build 7808031588

  • 0 of 6 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.006%) to 81.025%

Totals Coverage Status
Change from base Build 7805238433: -0.006%
Covered Lines: 6461
Relevant Lines: 7849

💛 - Coveralls

@papafe
Copy link
Contributor

papafe commented Feb 7, 2024

Looks good!

@papafe papafe merged commit 59232bf into fp/keypath-filtering Feb 7, 2024
75 of 80 checks passed
@papafe papafe deleted the ni/keypath-filtering branch February 7, 2024 06:16
papafe added a commit that referenced this pull request Feb 9, 2024
* A comment before pausing this for now

* Stub

* Added basic tests and keypath to extension mehtods

* Returned to initial implementation

* Stubs

* Updated core to v13.25.1

* Updated changelog

* Stub

* Stub

* Adding tests

* Fixed unsubuscription

* Added new tests

* Small cleaning up

* Added tests

* Added lots of tests

* Added more tests

* Moved tests down

* Slight improvement to handlers

* Corrected order of operations

* Improved docs

* Added tests

* Fixes

* Improved API

* Improved API and corrected tests

* Fixing API

* Removed test

* Small corrections

* Stub

* First step internal API unification

* almost finished unification

* Improved API unification

* Simplified API and added tests for collection construction [skip-ci]

* Small corrections

* Simplified with the use of marshaled vector

* Moved keypaths related to another file

* Small corrections [skip-ci]

* Small corrections

* Divided implementation

* Fixed API for collections

* Corrected tests

* Added missing tests

* Small fix

* Removed comment

* Fixes following PR

* Apply suggestions from code review

Co-authored-by: Nikola Irinchev <irinchev@me.com>

* Various PR comments fixes

* Various corrections according to PR

* Updated changelog and docs

* Fixes

* Changed marshaling to go around .net framework limitation

* Proposed delegate change (#3512)

* Small fix

* Update CHANGELOG.md

* Update Realm/Realm/DatabaseTypes/RealmCollectionBase.cs

---------

Co-authored-by: Nikola Irinchev <irinchev@me.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants