Copy bcsymbolmap files to build products folder when archiving #2759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -111,6 +111,14 @@ xcrealmswift() { | |||
| xc "-project $PROJECT $@" | |||
| } | |||
|
|
|||
| copy_bcsymbolmap() { | |||
There was a problem hiding this comment.
Could just be find "$1" -name '*.bcsymbolmap' -type f -exec cp {} "$2" \;
There was a problem hiding this comment.
Cool, thanks.
kishikawakatsumi
force-pushed
the
kk-bitcode-symbolmap
branch
from
d8f0150 to
fda411d
Compare
| echo "Copy .bcsymbolmap files to .xcarchive" | ||
| mv Realm.framework/*.bcsymbolmap RealmSwift.framework/*.bcsymbolmap "${CONFIGURATION_BUILD_DIR}" | ||
| else | ||
| # Delete *.bcsymbolmap files from framework bundle unless archiving |
There was a problem hiding this comment.
this says archiving, but above you're checking for "$ACTION" = "install". Are those actually the same?
There was a problem hiding this comment.
Yes, ACTION variable is to be build, clean, install, installhdrs, and installsrc. I confirmed the variable will be install when archiving.
|
Out of curiosity, how much larger does this make the binaries? |
|
@jpsim The size of each symbol files is 350KB for Realm and 150KB for RealmSwift. Compressed total size is around 200KB. |
1. Copy bcsymbolmap files to framework bundle 2. Move bcsymbolmap files from bundle to xcarchive whenever archiving
jpsim
force-pushed
the
kk-bitcode-symbolmap
branch
from
fda411d to
7cc31db
Compare
|
|
||
| if [ "$ACTION" = "install" ]; then | ||
| echo "Copy .bcsymbolmap files to .xcarchive" | ||
| find . -name '*.bcsymbolmap' -type f -exec mv {} "${CONFIGURATION_BUILD_DIR}" \; |
There was a problem hiding this comment.
@kishikawakatsumi I've generalized this so strip-frameworks.sh works for any framework, like the rest of this script. Could you please test this?
|
@kishikawakatsumi feel free to merge this once you've confirmed that my latest change is correct. |
|
@jpsim Thanks. I've confirmed/tested to work if other frameworks contain |
kishikawakatsumi
added a commit
that referenced
this pull request
Nov 9, 2015
Copy bcsymbolmap files to build products folder when archiving
Closed
1ec5
added a commit
to mapbox/mapbox-gl-native
that referenced
this pull request
Dec 14, 2015
Copied strip-frameworks.sh from realm/realm-swift@7cc31db for realm/realm-swift#2759. This script, which is embedded in the dynamic framework, strips out content for invalid architectures from any embedded framework and specifically strips out Simulator content when archiving to work around an App Store bug. Rewrote the iOS setup documentation. In particular, the MAPBOX_ACCESS_TOKEN environment variable is only for use with the iosapp demo application and doesn’t work in third-party applications.
1ec5
added a commit
to mapbox/mapbox-gl-native
that referenced
this pull request
Dec 21, 2015
Copied strip-frameworks.sh from realm/realm-swift@7cc31db for realm/realm-swift#2759. This script, which is embedded in the dynamic framework, strips out content for invalid architectures from any embedded framework and specifically strips out Simulator content when archiving to work around an App Store bug. Rewrote the iOS setup documentation. In particular, the MAPBOX_ACCESS_TOKEN environment variable is only for use with the iosapp demo application and doesn’t work in third-party applications.
1ec5
added a commit
to mapbox/mapbox-gl-native
that referenced
this pull request
Dec 23, 2015
Copied strip-frameworks.sh from realm/realm-swift@7cc31db for realm/realm-swift#2759. This script, which is embedded in the dynamic framework, strips out content for invalid architectures from any embedded framework and specifically strips out Simulator content when archiving to work around an App Store bug. Rewrote the iOS setup documentation. In particular, the MAPBOX_ACCESS_TOKEN environment variable is only for use with the iosapp demo application and doesn’t work in third-party applications.
1ec5
added a commit
to mapbox/mapbox-gl-native
that referenced
this pull request
Jan 6, 2016
Copied strip-frameworks.sh from realm/realm-swift@7cc31db for realm/realm-swift#2759. This script, which is embedded in the dynamic framework, strips out content for invalid architectures from any embedded framework and specifically strips out Simulator content when archiving to work around an App Store bug. Rewrote the iOS setup documentation. In particular, the MAPBOX_ACCESS_TOKEN environment variable is only for use with the iosapp demo application and doesn’t work in third-party applications.
1ec5
added a commit
to mapbox/mapbox-gl-native
that referenced
this pull request
Jan 20, 2016
Copied strip-frameworks.sh from realm/realm-swift@7cc31db for realm/realm-swift#2759. This script, which is embedded in the dynamic framework, strips out content for invalid architectures from any embedded framework and specifically strips out Simulator content when archiving to work around an App Store bug. Rewrote the iOS setup documentation. In particular, the MAPBOX_ACCESS_TOKEN environment variable is only for use with the iosapp demo application and doesn’t work in third-party applications.
1ec5
added a commit
to mapbox/mapbox-gl-native
that referenced
this pull request
Jan 22, 2016
Copied strip-frameworks.sh from realm/realm-swift@7cc31db for realm/realm-swift#2759. This script, which is embedded in the dynamic framework, strips out content for invalid architectures from any embedded framework and specifically strips out Simulator content when archiving to work around an App Store bug. Rewrote the iOS setup documentation. In particular, the MAPBOX_ACCESS_TOKEN environment variable is only for use with the iosapp demo application and doesn’t work in third-party applications.
1ec5
added a commit
to mapbox/mapbox-gl-native
that referenced
this pull request
Jan 22, 2016
Copied strip-frameworks.sh from realm/realm-swift@7cc31db for realm/realm-swift#2759. This script, which is embedded in the dynamic framework, strips out content for invalid architectures from any embedded framework and specifically strips out Simulator content when archiving to work around an App Store bug. Rewrote the iOS setup documentation. In particular, the MAPBOX_ACCESS_TOKEN environment variable is only for use with the iosapp demo application and doesn’t work in third-party applications.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*.bcsymbolmapfiles are necessary to submit an app with including debug symbols. If there are no those files, following error occurs unless uncheck "include app symbols ..."This PR makes it include the
*.bcsymbolmapfiles to the each framework bundles. Those files are moved to an app bundle when archiving.See also:
Missing BCSymbolMap for AppStore Submission - Xcode7B5
/cc @jpsim @mrackwitz