Fix PageViewController isScrollingFrom delegate when overshooting #669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When swiping fast to the next view controller, the scroll view will overshoot and trigger additional isScrollingFrom methods after didFinishScrollingFrom is called. This is expected, but the view controllers that are returned are the previously selected view controller and not the upcoming view controller. This was done to avoid triggered view controller appearance method (like viewWillAppear) for the upcoming view controllers when overshooting, but it seems like this is not happening anymore, so we can just remove this workaround.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When swiping fast to the next view controller, the scroll view will overshoot and trigger additional isScrollingFrom methods after didFinishScrollingFrom is called. This is expected, but the view controllers that are returned are the previously selected view controller and not the upcoming view controller. This was done to avoid triggered view controller appearance method (like viewWillAppear) for the upcoming view controllers when overshooting, but it seems like this is not happening anymore, so we can just remove this workaround.