Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PageViewController isScrollingFrom delegate when overshooting #669

Merged
merged 1 commit into from
Apr 2, 2023
Merged

Fix PageViewController isScrollingFrom delegate when overshooting #669

merged 1 commit into from
Apr 2, 2023

Commits on Apr 2, 2023

  1. Fix PageViewController isScrollingFrom delegate when overshooting 

    When swiping fast to the next view controller, the scroll view will
overshoot and trigger additional isScrollingFrom methods after
didFinishScrollingFrom is called. This is expected, but the view
controllers that are returned are the previously selected view
controller and not the upcoming view controller. This was done to
avoid triggered view controller appearance method (like
viewWillAppear) for the upcoming view controllers when overshooting,
but it seems like this is not happening anymore, so we can just remove
this workaround.
    @rechsteiner
    rechsteiner committed Apr 2, 2023
    Configuration menu
    Copy the full SHA
    5a7b032 View commit details
    Browse the repository at this point in the history