Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staging to master to add NCF hyperparameter tuning #1102

Merged
merged 64 commits into from
May 22, 2020
Merged

Conversation

miguelgfierro
Copy link
Collaborator

Description

Related Issues

#1092

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • This PR is being made to staging and not master.

Copy link
Collaborator

@loomlike loomlike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks and this is really cool! I left some comments but couldn't finish the review. Will work on a bit more tomorrow!
...
Ok, done checking. It would be much cleaner if we format codes. Also I found some files are missing the license term.

reco_utils/recommender/lightfm/lightfm_utils.py Outdated Show resolved Hide resolved
reco_utils/recommender/lightfm/lightfm_utils.py Outdated Show resolved Hide resolved
reco_utils/recommender/lightfm/lightfm_utils.py Outdated Show resolved Hide resolved
reco_utils/recommender/lightfm/lightfm_utils.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@loomlike loomlike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Great work. Really appreciate to all the contributors!

zzn2 and others added 7 commits May 20, 2020 16:56
For optional input port / parameters, the reference in implementation/args must be placed in
a nested list to indicate that it is optional.

Refer to https://aka.ms/azureml-module-optional-inputs for details.

For the subparameters (the ones that under another parameter's `options` section),
should also put the related args into nested lists, otherwise the module will fail to register
in the latest CLI tool.

This PR is to update the module spec to fix the issue.
Put sub parameters into nested arguments
Addressing comments for PR #1102 and some other fixes
@miguelgfierro miguelgfierro merged commit 558733f into master May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants