Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

controllers: Shut down OCS client CSV pods if not in provider mode #450

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

iamniting
Copy link
Member

@iamniting iamniting commented Jul 19, 2024

The ocs-client-operator is a dependency of the odf-operator, which gets installed regardless of whether the cluster is in provider mode. However, the client operator is not needed in non-provider mode. This change ensures that the client operator is shut down if the cluster is not in provider mode.

Signed-off-by: Nitin Goyal nigoyal@redhat.com

https://issues.redhat.com/browse/DFBUGS-17
https://bugzilla.redhat.com/show_bug.cgi?id=2299443

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 19, 2024
@iamniting iamniting force-pushed the provider-mess branch 2 times, most recently from cff2c1b to 94dbb2d Compare July 23, 2024 04:27
@iamniting iamniting requested review from nb-ohad and leelavg July 23, 2024 04:29
@iamniting
Copy link
Member Author

/cherry-pick release-4.16

@openshift-cherrypick-robot

@iamniting: once the present PR merges, I will cherry-pick it on top of release-4.16 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

controllers/storagesystem_controller.go Outdated Show resolved Hide resolved
controllers/subscriptions.go Show resolved Hide resolved
controllers/subscriptions.go Show resolved Hide resolved
controllers/subscriptions.go Outdated Show resolved Hide resolved
controllers/subscriptions.go Show resolved Hide resolved
@iamniting
Copy link
Member Author

/hold for testing

controllers/subscriptions.go Outdated Show resolved Hide resolved
controllers/subscriptions.go Outdated Show resolved Hide resolved
controllers/subscriptions.go Show resolved Hide resolved
The ocs-client-operator is a dependency of the odf-operator, which gets
installed regardless of whether the cluster is in provider mode. However,
the client operator is not needed in non-provider mode. This change ensures
that the client operator is shut down if the cluster is not in provider mode.

Signed-off-by: Nitin Goyal <nigoyal@redhat.com>
@nb-ohad
Copy link

nb-ohad commented Jul 23, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 23, 2024
Copy link
Contributor

openshift-ci bot commented Jul 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iamniting, nb-ohad

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@iamniting
Copy link
Member Author

/unhold

@openshift-merge-bot openshift-merge-bot bot merged commit 8244d55 into red-hat-storage:main Jul 23, 2024
16 of 17 checks passed
@openshift-cherrypick-robot

@iamniting: new pull request created: #457

In response to this:

/cherry-pick release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants