Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2299443:[release-4.16] controllers: Shut down OCS client CSV pods if not in provider mode #457

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #450

/assign iamniting

The ocs-client-operator is a dependency of the odf-operator, which gets
installed regardless of whether the cluster is in provider mode. However,
the client operator is not needed in non-provider mode. This change ensures
that the client operator is shut down if the cluster is not in provider mode.

Signed-off-by: Nitin Goyal <nigoyal@redhat.com>
@iamniting iamniting changed the title [release-4.16] controllers: Shut down OCS client CSV pods if not in provider mode Bug 2299443:[release-4.16] controllers: Shut down OCS client CSV pods if not in provider mode Jul 23, 2024
Copy link
Contributor

openshift-ci bot commented Jul 23, 2024

@openshift-cherrypick-robot: This pull request references Bugzilla bug 2299443, which is invalid:

  • expected the bug to target the "ODF 4.16.1" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2299443:[release-4.16] controllers: Shut down OCS client CSV pods if not in provider mode

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 23, 2024
Copy link
Contributor

openshift-ci bot commented Jul 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iamniting, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 23, 2024
@iamniting
Copy link
Member

/bugzilla refresh

Copy link
Contributor

openshift-ci bot commented Jul 23, 2024

@iamniting: This pull request references Bugzilla bug 2299443, which is invalid:

  • expected the bug to target the "ODF 4.16.1" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@iamniting
Copy link
Member

/bugzilla refresh

Copy link
Contributor

openshift-ci bot commented Jul 23, 2024

@iamniting: This pull request references Bugzilla bug 2299443, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.16.1) matches configured target release for branch (ODF 4.16.1)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (ebenahar@redhat.com), skipping review request.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit ca9bfd3 into red-hat-storage:release-4.16 Jul 23, 2024
18 checks passed
Copy link
Contributor

openshift-ci bot commented Jul 23, 2024

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 2299443 has been moved to the MODIFIED state.

In response to this:

Bug 2299443:[release-4.16] controllers: Shut down OCS client CSV pods if not in provider mode

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent bugzilla/valid-bug lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants