Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added installing stage for header files #147

Merged
merged 1 commit into from
Dec 4, 2018
Merged

Added installing stage for header files #147

merged 1 commit into from
Dec 4, 2018

Conversation

marcel-behlau-elfin
Copy link
Contributor

No description provided.

@redboltz
Copy link
Owner

redboltz commented Dec 4, 2018

Thank you for sending the PR. It looks good to me.

@redboltz redboltz merged commit 8bf70cb into redboltz:master Dec 4, 2018
@redboltz
Copy link
Owner

@marcel-behlau-elfin , I noticed that many C++ header only libraries don't place CMakeLists.txt in include directory. I think that we can move installing stage for header files functionality to root/CMakeLists.txt. What do you think?

@redboltz
Copy link
Owner

@marcel-behlau-elfin , after some study, I've changed my mind. The current implementation is well modularized. So we don't need updating implementation.

redboltz pushed a commit that referenced this pull request Oct 3, 2019
📚 Correct on-the-fly event creation documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants