feature: provide cmake find_package configuration #149

elfin-sbreuers · 2018-12-10T13:58:38Z

No description provided.

redboltz · 2018-12-17T14:15:16Z

Thank you for sending the PR.
After I merged #147 , I've checked some other project such as https://github.com/msgpack/msgpack-c/blob/master/CMakeLists.txt

I noticed that CMakeLists.txt in the include directory is unnatural. I think that we can remove it and add install operation to root CMakeLists.txt. Could you update the PR?

In addition,
https://github.com/redboltz/mqtt_cpp/pull/149/files#diff-46193e2e675adcde81f1d095d8b3e1dbR7
doesn't seem good. -lboost_system is UNIX specific notation. Maybe you need to use CMakeVariables something like ${Boost_SYSTEM_LIBRARY}. See https://github.com/msgpack/msgpack-c/blob/master/example/cpp03/CMakeLists.txt#L97

redboltz · 2018-12-19T13:06:06Z

@elfin-sbreuers , I got confused that #147 is your pull request. But it is by @marcel-behlau-elfin.
Sorry for the mix-up.

Anyway, I'd like to remove include/CMakeLists.txt and move the same functionality to ../CMakeLists.txt.

I'm not expert of cmake. If placing include/CMakeLists.txt is better way than implement the functionality in ../CMakeLists.txt, please let me know.

redboltz · 2018-12-19T14:19:58Z

See the comment #147 (comment)

@marcel-behlau-elfin , could you review the PR? I'm not sure how to provide cmake find_package.

redboltz · 2019-01-08T12:01:08Z

include/CMakeLists.txt


-target_include_directories(mqtt_cpp_iface INTERFACE ${HDR_ROOT} ${HDR_MQTT})
+target_link_libraries(${PROJECT_NAME} INTERFACE ${Boost_SYSTEM_LIBRARIES} -lpthread)


I think that ${Boost_SYSTEM_LIBRARIES} isn't defined.
According to the document https://cmake.org/cmake/help/v3.8/module/FindBoost.html

Boost_<C>_LIBRARY - Libraries to link for component <C> (may include target_link_libraries debug/optimized keywords)

So you need to use ${Boost_SYSTEM_LIBRARY}

-lpthread is platform dependent.

See
https://github.com/redboltz/mqtt_cpp/blob/master/CMakeLists.txt#L42
https://github.com/redboltz/mqtt_cpp/blob/master/test/CMakeLists.txt#L36

redboltz · 2019-01-08T12:03:57Z

I don't know much about cmake find_package mechanism.
Could you tell me how your modification works?
Why target_link_libraries is required? mqtt_cpp is a header only library. Is it for resolve dependency?

elfin-sbreuers · 2019-01-09T08:12:03Z

Hello,

Thanks for your valuable input. I updated the CMakeLists.txt according to your recommandations and added a Config.cmake file that allows for a proper usage in modern cmake applications. This includes the necessary link dependencies for threads and boost libraries.

You library is a header only library, but when using the boost system library, it is not header only, the system library needs to be added.

I did not move it up in the directory structure. I guess, one could argue about the right location of the installation procedure. I left it in includes, since the library is 'built' or located there and there should also be defined what is needed to properly build against the library.

Having said that, the inclusion and configuration of boost should probably go into the test/CMakeList.txt.

On a side note: apparently the usage of static boost libraries is only needed for your continuous-integration system. Your tests built just fine without it locally on my machine.

Are the current changes matching your requirements?

redboltz · 2019-01-12T10:48:31Z

Thank you for update the PR. I need a time to study cmake mechanism. Please wait a couple of days(hopefully ;)

redboltz · 2019-01-26T23:16:37Z

README.md

@@ -66,6 +66,17 @@ If you want to use MQTT on WebSocket, you need to define `MQTT_USE_WS` macro. mq
    * WebSocket
      * [example/tls_ws_both.cpp](https://github.com/redboltz/mqtt_cpp/blob/master/example/tls_ws_both.cpp)

+## Usage in cmake project
+
+Add following lines to your `CMakeList.txt`


It should be CmakeLists.txt.

redboltz · 2019-01-26T23:18:32Z

README.md

+
+```
+find_package(mqtt_cpp REQUIRED)
+target_link_libraries(${LIBNAME} LINK_PUBLIC mqtt_cpp::mqtt_cpp)


What does ${LIBNAME} mean?
If if is a users target name, it should be something like ${YOUR_TARGET}.

I've tested the PR on my environment.
I did make install mqtt_cpp. Then create the new cmake project.
The CMakeLists.txt is

PROJECT (mytest) find_package(mqtt_cpp REQUIRED) target_link_libraries(${PROJECT} LINK_PUBLIC mqtt_cpp::mqtt_cpp)

I did

make build cd build cmake -DCMAKE_FIND_DEBUG_MODE=1 ..

Then I got the following error:

CMake Error at CMakeLists.txt:4 (target_link_libraries): Cannot specify link libraries for target "LINK_PUBLIC" which is not built by this project.

Thanks for the input. I improved the readme. Apparently the target is missing that you add the target_link_libraries to. That means a target generation command like

add_library(${PROJECT_NAME} <dependencies>)

or

add_executable(${PROJECT_NAME} <dependencies>)

is missing.

The target_link_libraries call would then also need the following call

target_link_libraries(${PROJECT_NAME} mqtt_cpp::mqtt_cpp)

since the PROJECT variable itself is not set.

I still got the error.

I don't understand the following code at readme.

set(LIBNAME "your_project_name") add_library(${LIBNAME} <your dependencies here>) find_package(mqtt_cpp REQUIRED) target_link_libraries(${LIBNAME} LINK_PUBLIC mqtt_cpp::mqtt_cpp)

The user creates library? I think user creates application.

Could you give me complete and minimal example of CMakeLists.txt that uses installed mqtt_cpp?
I never success cmake, so far.

Create a library that uses mqtt_cpp

PROJECT(my_mqtt) MESSAGE(STATUS "Configuring ${PROJECT_NAME}") FILE(GLOB SRC "*.cpp") ADD_LIBRARY(my_mqtt ${SRC}) ADD_LIBRARY(my::mqtt ALIAS my_mqtt) TARGET_INCLUDE_DIRECTORIES(my_mqtt PUBLIC ${MY_FRAMEWORKS_ROOT}/inc/) TARGET_LINK_LIBRARIES(my_mqtt my::core my::log mqtt_cpp_iface Boost::system OpenSSL::SSL nlohmann_json::nlohmann_json )

Create an application that uses the library.

PROJECT(my-application) MESSAGE(STATUS "Configuring ${PROJECT_NAME}") FILE(GLOB SRC "*.cpp") ADD_EXECUTABLE(my-application ${SRC}) TARGET_LINK_LIBRARIES(my-application my::mqtt Boost::program_options) INSTALL(TARGETS my-application RUNTIME DESTINATION /usr/bin)

What this PR does is make it so someone (e.g., a distribution packager for a linux distribution) can install mqtt_cpp via "make install", and them someone else who wants to use mqtt_cpp, in their CMakeLists.txt, can use the CMake "find_package" command to locate mqtt_cpp on the filesystem and use the code in their own application.

I imagine that this change will also make it easier to satisfy this issue: #77 (but that's just speculation on my part. I know nothing of vcpkg)

redboltz · 2019-02-12T11:30:41Z

Could you rebase the PR from up to date master?

More minor tweaks pertaining to redboltz#230

Added ssl keylog callback for DEBUG.

…_server Added protocol_version setter for servers.

Users needed to set *_ref property types if the property has _ref type. It was annoying. Now, user can always use `::recv` type. It's simpler.

Refined visitor for properties.

Added MQTT v5 examples.

Acked-by: Takatoshi Kondo <redboltz@gmail.com>

Updated CHANGELOG and readme.

Added asynchronous pingreq sending mode. Use asynchronous mode from async_client.

Removed default parameter.

Fixed redboltz#266.

Migrated to azure-devops-build-pipelines from appveyor.

Supported codecov.

Added dupulicated travis-ci launch avoiding code.

Fixed redboltz#424.

…allback

Break the fixed header into dup, qos, and retain values for publish callback

Use v5 reason_code correctly.

Fixed redboltz#437.

Added missing async_handler_t call on disconnect. Removed error handling on do_sync_write(). If error happens the error will be handled by async_read. If `handle_error(ec);` is called in `do_sync_write()`, error_handler would be called twice. It is consistent behavior as `do_async_write()`.

Removed redundant handler reset code from test_broker. Added minimal support for Session Expiry Interval. Timer is not set yet.

Fix 435

…_with_any Replaced async_handler_t with any.

…quires the values be provided

…tional Fixes redboltz#391: Don't use mqtt::optional<> for the suback handler, as the standard requires the values be provided

…:shared_ptr<endpoint_t>. For `set_*_handler()`, capture `std::weak_ptr<endpoint_t>` at test_broker and examples. I think that `weak_ptr` is redundant. Reference is good enough because `shared_ptr` lifetime is kept by `start_session(life_keeper)`. However, `wp.lock()` is easy to detect if the lifetime is over unexpectedly.

Refactored test_broker parameter passing.

Updated the parameter of set_accept_handler() from endpoint_t to std:…

Bump to newest mqtt cpp

codecov-io · 2019-09-19T08:52:48Z

Codecov Report

Merging #149 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #149   +/-   ##
=======================================
  Coverage   84.94%   84.94%           
=======================================
  Files          40       40           
  Lines        6342     6342           
=======================================
  Hits         5387     5387           
  Misses        955      955

…f possible

…sible Check if boost beast is necessary, do reduce required boost version i…

jonesmz · 2019-09-19T19:02:13Z

CMakeLists.txt

 ELSE ()
    MESSAGE (STATUS "WebSocket disabled")
+    SET (BOOSTVERSION "1.59.0")


I'm not sure this is accurate anymore.

There were bigger changes that cause incompatibilities with versions of boost older than 1.67.

But if this does actually work, that'd be great to know about.

Ohh, you are right. This will be reverted.

…ersion if possible" This reverts commit 5194ea2.

…sible Revert "Check if boost beast is necessary, do reduce required boost v…

redboltz reviewed Jan 8, 2019

View reviewed changes

redboltz reviewed Jan 26, 2019

View reviewed changes

jonesmz mentioned this pull request Mar 22, 2019

Fix include/CMakeLists.txt #170

Merged

redboltz added 19 commits May 17, 2019 16:09

Merge pull request redboltz#246 from jonesmz/more_minor_tweaks

ce551af

More minor tweaks pertaining to redboltz#230

Merge pull request redboltz#256 from redboltz/add_ssl_keylog_cb

4fee682

Added ssl keylog callback for DEBUG.

Added protocol_version setter for servers.

be8c8e0

Merge pull request redboltz#257 from redboltz/add_protocol_version_to…

8f66221

…_server Added protocol_version setter for servers.

Refined visitor for properties.

1dadbe0

Users needed to set *_ref property types if the property has _ref type. It was annoying. Now, user can always use `::recv` type. It's simpler.

Merge pull request redboltz#258 from redboltz/refine_property_visitor

081f434

Refined visitor for properties.

Added MQTT v5 examples.

0e013d3

Merge pull request redboltz#259 from redboltz/add_v5_example_2

773ade4

Added MQTT v5 examples.

Updated CHANGELOG and readme.

e5512ad

Acked-by: Takatoshi Kondo <redboltz@gmail.com>

Merge pull request redboltz#260 from redboltz/update_to_v4.0.0

fa65497

Updated CHANGELOG and readme.

Fixed redboltz#266.

92338b1

Added asynchronous pingreq sending mode. Use asynchronous mode from async_client.

Fixed set_async_pingreq() argument.

1bbfb14

Removed default parameter.

Merge pull request redboltz#267 from redboltz/fix_266

5f62988

Fixed redboltz#266.

Migrated to azure-devops-build-pipelines from appveyor.

d1eda2c

Merge pull request redboltz#270 from redboltz/migrate_to_azure_pipelines

a2a6d7c

Migrated to azure-devops-build-pipelines from appveyor.

Supported codecov.

219ae2e

Merge pull request redboltz#273 from redboltz/add_codecov

449807f

Supported codecov.

Added dupulicated travis-ci launch avoiding code.

c72f354

Merge pull request redboltz#274 from redboltz/remove_dup_travis

aeaa2bf

Added dupulicated travis-ci launch avoiding code.

redboltz and others added 20 commits September 12, 2019 22:37

Fixed CMAKE_CXX_FLAGS empty case.

1cb3547

Merge pull request redboltz#425 from redboltz/fix_424

7c1bbb5

Fixed redboltz#424.

Break the fixed header into dup, qos, and retain values for publish c…

ed21620

…allback

Merge pull request redboltz#421 from jonesmz/11-publish-params

69ee912

Break the fixed header into dup, qos, and retain values for publish callback

Fixed redboltz#437.

4f831f7

Use v5 reason_code correctly.

Merge pull request redboltz#438 from redboltz/fix_437

bff8b87

Fixed redboltz#437.

Fixed tests.

8d11b53

Removed redundant handler reset code from test_broker. Added minimal support for Session Expiry Interval. Timer is not set yet.

Fixed typos.

88fdbb6

Moved connect_no_clean() to `test_util.hpp".

43521b1

Merge pull request redboltz#439 from redboltz/fix_435

f28140c

Fix 435

Replaced async_handler_t with any.

1fda86b

Merge pull request redboltz#442 from redboltz/replace_async_handler_t…

4b832b4

…_with_any Replaced async_handler_t with any.

Don't use mqtt::optional<> for the suback handler, as the standard re…

2cb318f

…quires the values be provided

Merge pull request redboltz#434 from jonesmz/suback-handler-remove-op…

10830cd

…tional Fixes redboltz#391: Don't use mqtt::optional<> for the suback handler, as the standard requires the values be provided

Added BOOST_ASSET() to inform lifetime.

932357d

Refactored test_broker parameter passing.

Merge pull request redboltz#443 from redboltz/accept_cb_shared_ptr

a17c6b2

Updated the parameter of set_accept_handler() from endpoint_t to std:…

Bump to newest version of mqtt_cpp master

c4bc289

Merge pull request #1 from marcel-behlau-elfin/bump_to_newest_mqtt_cpp

7db40bb

Bump to newest mqtt cpp

marcel-behlau-elfin and others added 2 commits September 19, 2019 14:25

Check if boost beast is necessary, do reduce required boost version i…

5194ea2

…f possible

Merge pull request #2 from marcel-behlau-elfin/downgrade_boost_if_pos…

2f6965c

…sible Check if boost beast is necessary, do reduce required boost version i…

jonesmz reviewed Sep 19, 2019

View reviewed changes

marcel-behlau-elfin and others added 2 commits September 23, 2019 07:48

Revert "Check if boost beast is necessary, do reduce required boost v…

45f6d31

…ersion if possible" This reverts commit 5194ea2.

Merge pull request #3 from marcel-behlau-elfin/downgrade_boost_if_pos…

9281b64

…sible Revert "Check if boost beast is necessary, do reduce required boost v…

redboltz closed this Oct 3, 2019

redboltz force-pushed the master branch from 9a63149 to 067d863 Compare October 3, 2019 01:46

marcel-behlau-elfin mentioned this pull request Jun 3, 2020

Deleted commits #631

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feature: provide cmake find_package configuration #149

feature: provide cmake find_package configuration #149

elfin-sbreuers commented Dec 10, 2018

redboltz commented Dec 17, 2018

redboltz commented Dec 19, 2018

redboltz commented Dec 19, 2018

redboltz Jan 8, 2019

redboltz commented Jan 8, 2019

elfin-sbreuers commented Jan 9, 2019

redboltz commented Jan 12, 2019

redboltz Jan 26, 2019

redboltz Jan 26, 2019

redboltz Jan 26, 2019

elfin-sbreuers Jan 28, 2019

elfin-sbreuers Jan 28, 2019

redboltz Feb 12, 2019

redboltz Feb 12, 2019

jonesmz Sep 19, 2019

jonesmz Sep 19, 2019

redboltz commented Feb 12, 2019

codecov-io commented Sep 19, 2019

jonesmz Sep 19, 2019

marcel-behlau-elfin Sep 23, 2019


		target_include_directories(mqtt_cpp_iface INTERFACE ${HDR_ROOT} ${HDR_MQTT})
		target_link_libraries(${PROJECT_NAME} INTERFACE ${Boost_SYSTEM_LIBRARIES} -lpthread)

feature: provide cmake find_package configuration #149

feature: provide cmake find_package configuration #149

Conversation

elfin-sbreuers commented Dec 10, 2018

redboltz commented Dec 17, 2018

redboltz commented Dec 19, 2018

redboltz commented Dec 19, 2018

Choose a reason for hiding this comment

redboltz commented Jan 8, 2019

elfin-sbreuers commented Jan 9, 2019

redboltz commented Jan 12, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

redboltz commented Feb 12, 2019

codecov-io commented Sep 19, 2019

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment