Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CodeAction to disable validation #531

Closed
angelozerr opened this issue Jan 12, 2022 · 5 comments · Fixed by #535
Closed

CodeAction to disable validation #531

angelozerr opened this issue Jan 12, 2022 · 5 comments · Fixed by #535
Assignees
Milestone

Comments

@angelozerr
Copy link
Contributor

When there is an error in qute template it should be nice to provide a code action to disable validation in other words update the proper validation settings like we do for application.properties validation.

When validation settings severity for each error code will be implemented it should be nice to provide an another code action to disable the settings for the given error code.

@angelozerr angelozerr self-assigned this Jan 12, 2022
@rgrunber rgrunber added this to the v0.11.0 milestone Jan 12, 2022
angelozerr added a commit to angelozerr/quarkus-ls that referenced this issue Jan 12, 2022
Fixes redhat-developer#531

Signed-off-by: azerr <azerr@redhat.com>
angelozerr added a commit to angelozerr/vscode-quarkus that referenced this issue Jan 12, 2022
See redhat-developer/quarkus-ls#531

Signed-off-by: azerr <azerr@redhat.com>
angelozerr added a commit to angelozerr/quarkus-ls that referenced this issue Jan 12, 2022
Fixes redhat-developer#531

Signed-off-by: azerr <azerr@redhat.com>
angelozerr added a commit to angelozerr/vscode-quarkus that referenced this issue Jan 13, 2022
See redhat-developer/quarkus-ls#531

Signed-off-by: azerr <azerr@redhat.com>
angelozerr added a commit to angelozerr/quarkus-ls that referenced this issue Jan 13, 2022
Fixes redhat-developer#531

Signed-off-by: azerr <azerr@redhat.com>
angelozerr added a commit to angelozerr/quarkus-ls that referenced this issue Jan 13, 2022
Fixes redhat-developer#531

Signed-off-by: azerr <azerr@redhat.com>
angelozerr added a commit to angelozerr/vscode-quarkus that referenced this issue Jan 13, 2022
See redhat-developer/quarkus-ls#531

Signed-off-by: azerr <azerr@redhat.com>
angelozerr added a commit to angelozerr/quarkus-ls that referenced this issue Jan 13, 2022
Fixes redhat-developer#531

Signed-off-by: azerr <azerr@redhat.com>
angelozerr added a commit to angelozerr/quarkus-ls that referenced this issue Jan 13, 2022
Fixes redhat-developer#531

Signed-off-by: azerr <azerr@redhat.com>
angelozerr added a commit to angelozerr/quarkus-ls that referenced this issue Jan 13, 2022
Fixes redhat-developer#531

Signed-off-by: azerr <azerr@redhat.com>
angelozerr added a commit that referenced this issue Jan 14, 2022
Fixes #531

Signed-off-by: azerr <azerr@redhat.com>
@angelozerr angelozerr reopened this Jan 14, 2022
angelozerr added a commit to redhat-developer/vscode-quarkus that referenced this issue Jan 14, 2022
See redhat-developer/quarkus-ls#531

Signed-off-by: azerr <azerr@redhat.com>
@angelozerr
Copy link
Contributor Author

I reopen the issue because we need to manage code action to disable validation but for a given file.

@fbricon have you some idea about the settings name that we can use it to define a set of templates.

A quick idea quarkus.tools.qute.validation.excluded String array:

"quarkus.tools.qute.validation.excluded" : [
  "*.items.qute.html"
  "*.book.qute.*"
]

It's simple but not powerfull (ex : we cannot configure some severity fo some error code for a given set of files).

@fbricon what do you think?

@fbricon
Copy link
Collaborator

fbricon commented Jan 14, 2022

It's good enough.

@angelozerr
Copy link
Contributor Author

It's good enough.

Ok thanks. I will implement it. The idea is to have 2 code actions:

  • Disable Qute validation updates quarkus.tools.qute.validation.enabled to false (disable validation for all templates). We have that in master.
  • Disable Qute validation for this file will add the file in the "quarkus.tools.qute.validation.excluded" String array.

I wonder if we need a code action like Disable Qute validation for '*/items.qute.* pattern` ?

@fbricon
Copy link
Collaborator

fbricon commented Jan 14, 2022

keep it simple for now, just this file pattern.

@angelozerr
Copy link
Contributor Author

Fixed by #535

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants