-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CodeAction to disable validation #535
CodeAction to disable validation #535
Conversation
This PR requires the PR on vscode side redhat-developer/vscode-quarkus#435 Please don't review the code (I did that very quickly) but it should work. |
3f249cf
to
942b8bf
Compare
...at.qute.ls/src/main/java/com/redhat/qute/services/diagnostics/TemplateCodeActionFactory.java
Outdated
Show resolved
Hide resolved
2f55529
to
fd1ac07
Compare
Fixes redhat-developer#531 Signed-off-by: azerr <azerr@redhat.com>
@fbricon you can review it now. |
So @mkouba suggests we have a validation setting per file instead. The setting would use an array of path/boolean entries instead of a single boolean. Or maybe we can do both (array OR boolean) |
The main problem with that is when your rename template file, it will require to update settings.json too. I think it's more work. Having a global validation enabled settings can be a good start. We can improve it in the future release, no? |
I think it's simple enough to support now and having to rename the value in the settings is only a small inconvenience. So I'd prefer having it. |
Ok but I think we should have this global validation settings to disable validation for all template files like we have for microprofile and xml language server. If you are agree with me, could we do that in an another PR? |
And I wonder if we must support pattern file instead of full file name because the question is do we need to store teh full pzth of the template or just the uri of the template (I mean the location uri with the project root basedir)? |
let's continue the discussion at #531 (comment) |
CodeAction to disable validation
Fixes #531
Signed-off-by: azerr azerr@redhat.com