Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CodeAction to disable validation #535

Merged

Conversation

angelozerr
Copy link
Contributor

CodeAction to disable validation

Fixes #531

Signed-off-by: azerr azerr@redhat.com

@angelozerr
Copy link
Contributor Author

This PR requires the PR on vscode side redhat-developer/vscode-quarkus#435

Please don't review the code (I did that very quickly) but it should work.

@angelozerr
Copy link
Contributor Author

Here a demo:

DisableValidation

@angelozerr angelozerr force-pushed the codeaction-validation-settings branch from 3f249cf to 942b8bf Compare January 13, 2022 10:53
@angelozerr angelozerr force-pushed the codeaction-validation-settings branch 4 times, most recently from 2f55529 to fd1ac07 Compare January 13, 2022 14:00
@angelozerr angelozerr marked this pull request as ready for review January 13, 2022 14:00
Fixes redhat-developer#531

Signed-off-by: azerr <azerr@redhat.com>
@angelozerr
Copy link
Contributor Author

@fbricon you can review it now.

@fbricon
Copy link
Collaborator

fbricon commented Jan 13, 2022

So @mkouba suggests we have a validation setting per file instead. The setting would use an array of path/boolean entries instead of a single boolean. Or maybe we can do both (array OR boolean)

@angelozerr
Copy link
Contributor Author

So @mkouba suggests we have a validation setting per file instead.

The main problem with that is when your rename template file, it will require to update settings.json too. I think it's more work. Having a global validation enabled settings can be a good start. We can improve it in the future release, no?

@fbricon
Copy link
Collaborator

fbricon commented Jan 13, 2022

I think it's simple enough to support now and having to rename the value in the settings is only a small inconvenience. So I'd prefer having it.

@angelozerr
Copy link
Contributor Author

angelozerr commented Jan 13, 2022

Ok but I think we should have this global validation settings to disable validation for all template files like we have for microprofile and xml language server.

If you are agree with me, could we do that in an another PR?

@angelozerr
Copy link
Contributor Author

And I wonder if we must support pattern file instead of full file name because the question is do we need to store teh full pzth of the template or just the uri of the template (I mean the location uri with the project root basedir)?

@angelozerr angelozerr merged commit 81844da into redhat-developer:master Jan 14, 2022
@angelozerr
Copy link
Contributor Author

I think it's simple enough to support now and having to rename the value in the settings is only a small inconvenience. So I'd prefer having it.

let's continue the discussion at #531 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CodeAction to disable validation
2 participants