Use ASPNETCORE_HTTP_PORTS and set APP_UID. #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This aligns with changes made to Microsoft images for .NET 8.
tmds
commented
Oct 4, 2023
| using Microsoft.AspNetCore.Hosting; | ||
| using Microsoft.AspNetCore.Builder; | ||
| using Microsoft.AspNetCore.Http; | ||
| var builder = WebApplication.CreateBuilder(args); |
There was a problem hiding this comment.
The ASPNETCORE_HTTP_PORTS was introduced in a backwards compatible way.
It seems the backwards compatibility does not include the old WebHost API which this example was still using.
I've created an issue: dotnet/aspnetcore#51125.
We should follow what comes out.
There was a problem hiding this comment.
I don't like introducing a non-breaking change when it is not needed,
though I prefer to follow what Microsoft does here, and document the breaking change.
If Microsoft makes some further changes to avoid the breaking change, we can sync again for those.
aslicerh
approved these changes
Oct 9, 2023
|
@aslicerh, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aligns with changes made to Microsoft images for .NET 8.
Fixes #448.