Revert adopting ASPNETCORE_HTTP_PORTS. #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Microsoft .NET 8 images adopt ASPNETCORE_HTTP_PORTS in favor of ASPNETCORE_URLS. This new envvar provides a slightly user-friendlier alternative to control the port ASP.NET Core applications listen on. For Microsoft images this change goes together with changing from port 80 to port 8080. This means users are anyhow confronted with a breaking change. For Red Hat images we were already using port 8080 and continue using that same port. When updating our images to use ASPNETCORE_HTTP_PORTS instead of ASPNETCORE_URLS we learned that the new environment variable is not recognized by ASP.NET Core applications that use the older WebHost API. This causes such applications to bind to port 5000 instead of port 8080. To avoid breaking these applications, we revert the changes to adopt ASPNETCORE_HTTP_PORTS and stick to using ASPNETCORE_URLS.
aslicerh
approved these changes
Oct 16, 2023
|
Thanks for reviewing @aslicerh! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Microsoft .NET 8 images adopt ASPNETCORE_HTTP_PORTS in favor of ASPNETCORE_URLS.
This new envvar provides a slightly user-friendlier alternative to control the port ASP.NET Core applications listen on.
For Microsoft images this change goes together with changing from port 80 to port 8080.
This means users are anyhow confronted with a breaking change.
For Red Hat images we were already using port 8080 and continue using that same port.
When updating our images to use ASPNETCORE_HTTP_PORTS instead of ASPNETCORE_URLS we learned that the new environment variable is not recognized by ASP.NET Core applications that use the older WebHost API. This causes such applications to bind to port 5000 instead of port 8080.
To avoid breaking these applications, we revert the changes to adopt ASPNETCORE_HTTP_PORTS and stick to using
ASPNETCORE_URLS.
Partly reverts #472.