Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit pipeline tree load #240

Closed
evidolob opened this issue Apr 8, 2020 · 0 comments · Fixed by #255
Closed

Revisit pipeline tree load #240

evidolob opened this issue Apr 8, 2020 · 0 comments · Fixed by #255
Assignees
Labels
enhancement New feature or request in progress ui/ux issues related to user interface / user experience
Milestone

Comments

@evidolob
Copy link
Collaborator

evidolob commented Apr 8, 2020

Now when user open pipeline tree we first create root tree items, for each of them load child and only after that we show root items in the tree.
We trying to use cache for all tekton tree items, but, for some reasons we put in the cache Pipeline nodes but never get them from cache.

I think that showing tekton tree and root items fast and than load only nodes that user wants to open(on tree item expand) will be much better UX than current implementation when we have a long load period for root items and then again we re load Pipeline nodes. Such behavior can be a problem on slow internet connection or when we have big set of different tekton objects in a cluster.

So I propose next:

  • rework tekton tree to lazy load for all nodes, without pre-cache
  • use cache for some requests, like getting taskruns
  • Improve tekton tree refresh Improve tekton tree refresh  #239
@evidolob evidolob added enhancement New feature or request ui/ux issues related to user interface / user experience labels Apr 8, 2020
@evidolob evidolob self-assigned this Apr 8, 2020
@evidolob evidolob added this to the Sprint #182 milestone Apr 15, 2020
evidolob added a commit that referenced this issue Apr 17, 2020
Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
evidolob added a commit that referenced this issue Apr 22, 2020
* #240 use 'kubectl' insted of 'tkn' for tree, some minor refactorings

Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>

* Refresh all tree after pipelinerun end, sort pipelinerun and taskrun nodes

Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>

* fix 'status.completionTime' access

Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>

* Refresh 'TaskRuns', 'ClusterTasks', 'Tasks' nodes on each pipelinerun status change

Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>

* Refresh tree root nodes

Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request in progress ui/ux issues related to user interface / user experience
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant