Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 'kubectl' instead of 'tkn' for tree, some minor refactoring #255

Merged
merged 6 commits into from
Apr 22, 2020

Conversation

evidolob
Copy link
Collaborator

This PR increase Tekton tree loading speed. Also now Tekton tree use only kubectl to get data for nodes.
Also it add better update tree when pipelinerun is running.

Demo:
ezgif com-video-to-gif (3)

Fix: #240
Fix: #239

Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
@evidolob evidolob self-assigned this Apr 17, 2020
@codecov-io
Copy link

codecov-io commented Apr 17, 2020

Codecov Report

Merging #255 into master will decrease coverage by 1.13%.
The diff coverage is 79.20%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #255      +/-   ##
==========================================
- Coverage   71.18%   70.04%   -1.14%     
==========================================
  Files          38       38              
  Lines        2391     2357      -34     
  Branches      405      402       -3     
==========================================
- Hits         1702     1651      -51     
- Misses        689      706      +17     
Impacted Files Coverage Δ
src/tekton/pipelinerun.ts 100.00% <ø> (ø)
src/kubectl.ts 12.82% <33.33%> (ø)
src/util/tektonresources.virtualfs.ts 83.67% <50.00%> (-0.17%) ⬇️
src/cli.ts 67.21% <65.00%> (-9.35%) ⬇️
src/tkn.ts 75.62% <82.25%> (-3.60%) ⬇️
src/kubernetes.ts 100.00% <100.00%> (ø)
src/pipeline/pipelineExplorer.ts 64.28% <100.00%> (+0.64%) ⬆️
src/tekton/pipeline.ts 35.60% <100.00%> (ø)
src/tekton/tektonitem.ts 91.30% <100.00%> (ø)
src/tools.ts 94.56% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 103e5f1...28a9438. Read the comment docs.

src/tkn.ts Show resolved Hide resolved
@sudhirverma
Copy link
Contributor

And also I get the error while automatic refreshing the tree

Screenshot 2020-04-17 at 2 17 03 PM

@evidolob
Copy link
Collaborator Author

And also I get the error while automatic refreshing the tree

Screenshot 2020-04-17 at 2 17 03 PM

@sudhirverma I don't see that error, can you share the pipeline?

…nodes

Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
… status change

Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
@sudhirverma
Copy link
Contributor

I think we should refresh the separate node of taskRun as we are refreshing the taskRun under pipelineRun.

Screenshot 2020-04-21 at 5 28 39 PM

Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
@evidolob
Copy link
Collaborator Author

@sudhirverma That should be fixed.

…to tree-with-kubectl

Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
@evidolob evidolob merged commit 254f4a4 into master Apr 22, 2020
@evidolob evidolob deleted the tree-with-kubectl branch April 22, 2020 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revisit pipeline tree load Improve tekton tree refresh
3 participants