Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Tekton: Follow Log' command for PipelineRuns and TaskRuns #99

Merged
merged 2 commits into from
Dec 10, 2019

Conversation

sudhirverma
Copy link
Contributor

Fix: #93

@codecov-io
Copy link

codecov-io commented Dec 6, 2019

Codecov Report

Merging #99 into master will increase coverage by 0.27%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #99      +/-   ##
==========================================
+ Coverage   72.29%   72.57%   +0.27%     
==========================================
  Files          19       19              
  Lines         989      999      +10     
  Branches      148      148              
==========================================
+ Hits          715      725      +10     
  Misses        274      274
Impacted Files Coverage Δ
src/extension.ts 86.25% <100%> (+0.35%) ⬆️
src/tekton/pipelinerun.ts 100% <100%> (ø) ⬆️
src/tkn.ts 78.22% <100%> (+0.25%) ⬆️
src/tekton/taskrun.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b04000...6979842. Read the comment docs.

@sudhirverma sudhirverma changed the title 'Tekton: Follow Log' command for PipelineRuns and TaskRuns [WIP] 'Tekton: Follow Log' command for PipelineRuns and TaskRuns Dec 6, 2019
Copy link
Contributor

@dgolovin dgolovin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename static methods 'followLog' to 'followLogs', method name should be the same as last segment of command identifier. This is required for tests to be able to find method corresponding to command.

@dgolovin dgolovin merged commit 5cced1d into redhat-developer:master Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'Tekton: Follow Log' command for PipelineRuns and TaskRuns
3 participants