feat: refactoring and tests #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Click here to review and test in web IDE: |
themr0c
force-pushed
the
feat-rules-consolidate
branch
3 times, most recently
from
7c3f041
to
5cf3b0a
Compare
|
Status: The alerts are not the same (testing che-docs master branch). Need more in depth tests. main: ✖ 128 errors, 502 warnings and 3200 suggestions in 764 files. this branch: ✖ 217 errors, 40 warnings and 9769 suggestions in 764 files. |
themr0c
force-pushed
the
feat-rules-consolidate
branch
2 times, most recently
from
5f68140
to
c2b5bb7
Compare
feat: add tests
themr0c
force-pushed
the
feat-rules-consolidate
branch
3 times, most recently
from
9589230
to
26dd193
Compare
themr0c
changed the title
themr0c
force-pushed
the
feat-rules-consolidate
branch
2 times, most recently
from
d2cbfa6
to
89a7672
Compare
themr0c
force-pushed
the
feat-rules-consolidate
branch
from
89a7672
to
6413dfc
Compare
feat: test suite generator update_test_suite feat: generate test suites feat: run update_reference_guide and update_test_suite during preview feat: umask 002 to avoid issues with rights on new files feat: add tests for all rules feat: fix rules using tests
|
After updates: testing che-docs
The rules in this branch are currently better than the rules in the main branch. |
themr0c
force-pushed
the
feat-rules-consolidate
branch
2 times, most recently
from
72bf5a3
to
9713959
Compare
|
Now we know where we stand: |
feat: fix rules using the test suite
themr0c
force-pushed
the
feat-rules-consolidate
branch
2 times, most recently
from
1cb4b38
to
d9be877
Compare
feat: refactoring rules further feat: all rules pass the tests
themr0c
force-pushed
the
feat-rules-consolidate
branch
from
d9be877
to
19e1469
Compare
|
I have some doubt about raising an error for any occurrence of |
feat: alphabetical ordering in test files
This was referenced Feb 1, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TLDR: Fewer rules, all tested. Reference guide less overwhelming.
feat: consolidate the rules in fewer files (25 rules rather than 295)
feat: remove rules that are not defined in supplementary style guide or underlying style guides
feat: order fields consistently in rules
feat: point
link:in rules to vale-at-red-hat docsfeat: point
source:in rules to supplementary style guidefeat: create
tools/generate_vale_rule_tests.shfeat: create
tools/test_vale_rules.shfeat: generate vale rule tests
feat: generate reference guide and vale rule tests during preview
feat: refactor build script
feat: author extensive tests for all rules
feat: all rules pass the tests