Handle empty object references in Image Streams #1206
Merged
+10
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jose R. Gonzalez <komish@flutes.dev>
openshift-ci
bot
added
the
approved
|
from change #1206: |
skattoju
approved these changes
Oct 10, 2024
|
/test 4.13-e2e |
acornett21
approved these changes
Oct 15, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: acornett21, komish, skattoju The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ImageStream{}.Tags[].Fromis a pointer to a corev1.ObjectReference and, and if it's missing, we'll panic because we access a field within without checking if it exists.This PR updates this logic so that it will only pull the reference if it exists. A corresponding test entry has been added.