Bugfix: Ignore timeout callback from a successful connect (fixes #945) #935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kristjanvalur
changed the title
|
fixes #945 |
kristjanvalur
changed the title
|
Thanks for the fix, merged. |
|
Sounds good. I plan on merging the adapter too but wanted to run it locally a bit so I have a good enough understanding of it to answer questions about it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
redisAsyncConnectis done with a connect_timeout, and subsequently a redisAsyncCommand() happens but with no command_timeout, the connect timeout can still arrive, since it is never cancelled. This fix prevents such a belated timeout from cancelling a command.