Pr1-7 roll-up plus unittests for async API and regression tests for async bugs #948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kristjanvalur
changed the title
kristjanvalur
changed the title
|
Hi, @kristjanvalur I'll probably go through each of the PRs individually so we merge changes in smaller chunks. We're likely to miss something merging such a large PR. |
|
Absolutely. The intention for me with the big pr was to bring everything
together, with tests, and GitHub actions integration and make sure that it
works. There are some interdependencies to get it all beautifully wrapped
up like that :)
fim., 6. maí 2021 kl. 22:21 skrifaði Michael Grunder <
***@***.***>:
… Hi, @kristjanvalur <https://github.com/kristjanvalur> I'll probably go
through each of the PRs individually so we merge changes in smaller chunks.
We're likely to miss something merging such a large PR.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#948 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABN3FRZ4FEMO77SAY2NEYKLTMMI7XANCNFSM43I2JKAQ>
.
|
Other tests can be added, and they rely on bug fixes that have not yet been added to master.
Skipped tests result in errors during unittest.
specifying a REDIS_DOCKER env var will run this as a server.
…y deferring context deletion
Removes warnings on windows. Fixes at least one bug, negating an unsigned int.
|
This was only ever a demo PR, showing a roundup of individual changes, tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A combined pull request, combining pr1-7 from me (minus doc pr4)
Also includes test_async() in test.c, utilizint the
polladapter, which makes it simple to test async functionality.Includes regression tests for the three bugfixes in those pull requests.
GitHub actions CI has been performed on branch
devin kristjanvalur/hiredis, see https://github.com/kristjanvalur/hiredis/actions