Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] RESP3 Support #3293

Merged
merged 12 commits into from
Mar 28, 2023
Merged

[WIP] RESP3 Support #3293

merged 12 commits into from
Mar 28, 2023

Conversation

sazzad16
Copy link
Collaborator

  • Added protocol selection (RESP2/RESP3)
  • Added internal HELLO command
  • Added RESP3 reply 'readers'; not necessarily parsers; simplified map/set

@sazzad16 sazzad16 marked this pull request as draft February 15, 2023 12:12
@codecov-commenter
Copy link

codecov-commenter commented Feb 27, 2023

Codecov Report

Patch coverage: 59.79% and project coverage change: -0.29 ⚠️

Comparison is base (4a8b9e7) 67.06% compared to head (47aeba3) 66.77%.

❗ Current head 47aeba3 differs from pull request most recent head 013dca8. Consider uploading reports for the commit 013dca8 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@             Coverage Diff              @@
##                5.0    #3293      +/-   ##
============================================
- Coverage     67.06%   66.77%   -0.29%     
+ Complexity     4662     4655       -7     
============================================
  Files           263      263              
  Lines         15092    15131      +39     
  Branches        952      950       -2     
============================================
- Hits          10121    10104      -17     
- Misses         4566     4615      +49     
- Partials        405      412       +7     
Impacted Files Coverage Δ
.../main/java/redis/clients/jedis/BuilderFactory.java 74.58% <ø> (ø)
...ava/redis/clients/jedis/util/RedisInputStream.java 53.15% <0.00%> (-10.98%) ⬇️
src/main/java/redis/clients/jedis/Connection.java 79.27% <55.17%> (-3.65%) ⬇️
src/main/java/redis/clients/jedis/Protocol.java 86.04% <78.78%> (-4.70%) ⬇️
.../redis/clients/jedis/DefaultJedisClientConfig.java 96.66% <100.00%> (+1.37%) ⬆️
...in/java/redis/clients/jedis/JedisClientConfig.java 93.75% <100.00%> (+0.41%) ⬆️
...c/main/java/redis/clients/jedis/RedisProtocol.java 100.00% <100.00%> (ø)

... and 21 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@chayim chayim changed the base branch from master to 5.0 March 28, 2023 06:36
@chayim chayim marked this pull request as ready for review March 28, 2023 07:01
@chayim chayim merged commit 6e9177b into redis:5.0 Mar 28, 2023
@sazzad16 sazzad16 deleted the resp-1 branch May 3, 2023 15:31
@sazzad16 sazzad16 added this to the 5.0.0 milestone Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants